Retrieved Hostlist information from Directory service.

remoting/test/chromoting_host_info.h

Index: remoting/test/chromoting_host_info.h
diff --git a/remoting/test/chromoting_host_info.h b/remoting/test/chromoting_host_info.h
new file mode 100644
index 0000000000000000000000000000000000000000..dbcbe4e98af39f224f624af725aae6cba8b17a15
--- /dev/null
+++ b/remoting/test/chromoting_host_info.h
@@ -0,0 +1,39 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_TEST_CHROMOTING_HOST_INFO_H_
+#define REMOTING_TEST_CHROMOTING_HOST_INFO_H_
+
+#include <string>
+#include <vector>
+
+#include "base/values.h"
+
+namespace remoting {
+namespace test {
+
+enum ChromotingHostStatus {
+  kChromotingHostStatusOnline,
+  kChromotingHostStatusOffline
+};
+
+struct ChromotingHostInfo {

[Sergey Ulanov, 2015/07/08 19:57:33]

I think this can be called HostInfo. it's already in remoting:: namespace so
Chromoting prefix seems redundant.

[tonychun, 2015/07/08 22:38:15]

Done.

+  ChromotingHostInfo();
+  ~ChromotingHostInfo();
+
+  bool ParseHostInfo(const base::DictionaryValue& host_info);
+
+  std::string host_id;
+  std::string host_jid;
+  std::string host_name;
+  ChromotingHostStatus status = kChromotingHostStatusOffline;

[joedow, 2015/07/08 17:19:07]

This would be better if you set this in the C'Tor initializer list

[Sergey Ulanov, 2015/07/08 19:57:34]

Style guide says:
  Use in-class member initialization for simple initializations, especially when
a member variable must be initialized the same way in more than one constructor.

IMO it's good idea to use in-class initialization here. It ensures that the
field is always initialized and makes it clear what's the default value for this
field. We didn't have this feature before C++11 that's why a lot of code still
uses initializer lists.

[tonychun, 2015/07/08 22:38:15]

Done.

+  std::string offline_reason;
+  std::string public_key;
+  std::vector<std::string> token_url_patterns;
+};
+
+}  // namespace test
+}  // namespace remoting
+
+#endif  // REMOTING_TEST_CHROMOTING_HOST_INFO_H_