Retrieved Hostlist information from Directory service.

remoting/test/chromoting_host_info.h

Index: remoting/test/chromoting_host_info.h
diff --git a/remoting/test/chromoting_host_info.h b/remoting/test/chromoting_host_info.h
new file mode 100644
index 0000000000000000000000000000000000000000..8cab7996970523f79820283d5900ca273edbb38b
--- /dev/null
+++ b/remoting/test/chromoting_host_info.h
@@ -0,0 +1,32 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_TEST_CHROMOTING_HOST_INFO_H_
+#define REMOTING_TEST_CHROMOTING_HOST_INFO_H_
+
+#include <string>
+#include <vector>
+
+#include "base/values.h"
+
+namespace remoting {
+namespace test {
+
+struct ChromotingHostInfo {
+  ChromotingHostInfo(const base::DictionaryValue& item);

[joedow, 2015/07/01 03:39:33]

Single argument constructors must be marked explicit.

Have you run cpplint.py on the C++ files you changed/added?  It is in the
depot_tools folder and will catch stuff like this before the code goes out for
review.

[tonychun, 2015/07/06 20:11:50]

Done.

+  ~ChromotingHostInfo();
+
+  std::vector<std::string> tokenUrlPatterns;

[joedow, 2015/07/01 03:39:34]

nit: why is this the first member?  It seems like this should be lower down in
the list (with host_id being first) 

[tonychun, 2015/07/06 20:11:50]

Done.

+  std::string id;

[joedow, 2015/07/01 03:39:34]

nit: host_id and host_jid would be more readable.  The struct is HostInfo, but
someone will probably create an instance of the struct and call it 'info' and
then this member will be info.id which is not readable.

[tonychun, 2015/07/06 20:11:50]

Done.

+  std::string jid;
+  std::string name;
+  std::string offline_reason;
+  std::string public_key;
+  bool is_online;

[joedow, 2015/07/01 03:39:33]

nit: move this above 'offline_reason'?

[tonychun, 2015/07/06 20:11:50]

Done.

+};
+
+}  // namespace test
+}  // namespace remoting
+
+#endif  // REMOTING_TEST_CHROMOTING_HOST_INFO_H_