Retrieved Hostlist information from Directory service.

remoting/test/chromoting_host_info.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "remoting/test/chromoting_host_info.h"
+
+#include "base/logging.h"
+
+namespace remoting {
+namespace test {
+
+ChromotingHostInfo::ChromotingHostInfo() {
+}
+
+ChromotingHostInfo::~ChromotingHostInfo() {
+}
+
+bool ChromotingHostInfo::ParseHostInfo(const base::DictionaryValue& host_info) {
+  const base::ListValue* list_value = nullptr;
+
+  // Add TokenUrlPatterns to ChromotingHostInfo

[joedow, 2015/07/08 17:19:07]

comments need to end in periods, please add one here.

[tonychun, 2015/07/08 22:38:15]

Done.

+  if (host_info.GetList("tokenUrlPatterns", &list_value)) {
+    int size = list_value->GetSize();
+    if (size > 0) {
+      std::string token_url_pattern;
+      for (int i = 0; i < size; ++i) {
+        list_value->GetString(i, &token_url_pattern);
+        if (!token_url_pattern.empty()) {
+          token_url_patterns.push_back(token_url_pattern);
+        }
+      }
+    }
+  }
+
+  std::string response_status;
+  host_info.GetString("status", &response_status);
+  if (response_status == "ONLINE") {
+    status = kChromotingHostStatusOnline;
+  } else if (response_status == "OFFLINE") {
+    status = kChromotingHostStatusOffline;
+  } else {
+    LOG(ERROR) << "Response Status is " << response_status;
+    NOTREACHED();

[Sergey Ulanov, 2015/07/08 19:57:33]

return false?
NOTREACHED is equivalent to DCHECK(false) and you should never DCHECK on the
data received from outside.

[tonychun, 2015/07/08 22:38:15]

Done.

+  }
+
+  if (!host_info.GetString("hostId", &host_id)) {
+    LOG(ERROR) << "hostId was not found in host_info";
+    return false;
+  }

[joedow, 2015/07/08 17:19:07]

nit: I'd prefer to see newlines in between each chunk of code which handles a
property, makes it easier to parse

[tonychun, 2015/07/08 22:38:15]

Done.

+  if (!host_info.GetString("hostName", &host_name)) {
+    LOG(ERROR) << "hostName was not found in host_info";
+    return false;
+  }
+  if (!host_info.GetString("publicKey", &public_key)) {
+    LOG(ERROR) << "publicKey was not found for " << host_name;
+    return false;
+  }
+  // If the host entry was created but the host was never online, then the jid
+  // is never set.
+  if (!host_info.GetString("jabberId", &host_jid)) {

[joedow, 2015/07/08 17:19:07]

Should you check to see if online is set here?  It sounds like no jid for an
online host would be a failure.

[tonychun, 2015/07/08 22:38:15]

Done.

+    LOG(INFO) << "jabberId was not found for " << host_name;
+  }
+  // If the host was never running or if it was started and it's still running,
+  // then the hostOfflineReason will not be set. It is only set after the host
+  // goes offline.
+  if (!host_info.GetString("hostOfflineReason", &offline_reason)) {
+    LOG(INFO) << "hostOfflineReason was not found for " << host_name;
+  }
+
+  return true;
+}
+
+}  // namespace test
+}  // namespace remoting