Retrieved Hostlist information from Directory service.

remoting/test/chromoting_host_info.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_TEST_CHROMOTING_HOST_INFO_H_
+#define REMOTING_TEST_CHROMOTING_HOST_INFO_H_
+
+#include <string>
+#include <vector>
+
+#include "base/values.h"
+
+namespace remoting {
+namespace test {
+
+enum ChromotingHostStatus {
+  kChromotingHostStatusOnline,
+  kChromotingHostStatusOffline

[joedow, 2015/07/06 22:19:12]

A good practice with enums is to add a value at the end that you can use to test
for validity.  An example of this is in app_remoting_service_urls.h

[Sergey Ulanov, 2015/07/07 00:01:45]

IMO it's better to avoid "null" values, unless they are actually useful. (for
the similar reasons reason null values are evil, e.g. see
http://programmers.stackexchange.com/questions/12777/are-null-references-real...
. It's one more case for the code to handle and it's easy to miss it).
E.g. one case when null/unknown values can be useful in enums is when parsing
user input to indicate invalid parameter. In this particular enum it might be
useful to indicate that the service didn't supply status for the host, but I'm
not sure it's necessary to distinguish that case from the host being offline
OFFLINE.

[tonychun, 2015/07/08 03:12:13]

I have added LOG(ERROR) and NOTREACHED() to print a status that is neither
"online" or "offline".

[tonychun, 2015/07/08 03:12:13]

The reason I didn't do this is because currently there are only two. I will add
it in anyway.

+};
+
+struct ChromotingHostInfo {
+  explicit ChromotingHostInfo(const base::DictionaryValue& item);

[joedow, 2015/07/06 22:19:12]

item?  can you make this more descriptive?

[tonychun, 2015/07/08 03:12:13]

Done.

+  ~ChromotingHostInfo();
+
+  std::string host_id;
+  std::string host_jid;
+  std::string host_name;
+  ChromotingHostStatus status;

[Sergey Ulanov, 2015/07/07 00:01:45]

Specify default value here (i.e. add = kChromotingHostStatusOffline) as this is
a simple type and will not be initialized automatically.

[tonychun, 2015/07/08 03:12:13]

Done.

+  std::string offline_reason;
+  std::string public_key;
+  std::vector<std::string> tokenUrlPatterns;

[joedow, 2015/07/06 22:19:12]

token_url_patterns

[tonychun, 2015/07/08 03:12:13]

Done.

+};
+
+}  // namespace test
+}  // namespace remoting
+
+#endif  // REMOTING_TEST_CHROMOTING_HOST_INFO_H_