Retrieved Hostlist information from Directory service.

remoting/test/chromoting_host_info.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "remoting/test/chromoting_host_info.h"
+
+#include "base/logging.h"
+
+namespace remoting {
+namespace test {
+
+ChromotingHostInfo::ChromotingHostInfo(const base::DictionaryValue& item) {
+  const base::ListValue* listValue = nullptr;
+  item.GetList("data.tokenUrlPatterns", &listValue);
+
+  // Add TokenUrlPatterns to ChromotingHostInfo
+  if(listValue != nullptr) {

[joedow, 2015/07/01 03:39:33]

add space between if and open paren

[tonychun, 2015/07/06 20:11:50]

Done.

+    int size = listValue->GetSize();
+    if (size > 0) {
+      std::string tokenUrlPattern;
+      for(int i = 0; i < size; ++i) {

[joedow, 2015/07/01 03:39:33]

add space between for and open paren (please run cpplint.py)

[tonychun, 2015/07/06 20:11:50]

Done.

+        listValue->GetString(i,&tokenUrlPattern);

[joedow, 2015/07/01 03:39:33]

add space between comma and ampersand

[tonychun, 2015/07/06 20:11:50]

Done.

+        if(!tokenUrlPattern.empty()) {

[joedow, 2015/07/01 03:39:33]

Add space between if and open paren (please run cpplint.py)

[tonychun, 2015/07/06 20:11:50]

Done.

+          tokenUrlPatterns.push_back(tokenUrlPattern);
+        }
+      }
+    }
+  }
+
+  item.GetString("hostId", &id);

[joedow, 2015/07/01 03:39:33]

tokenUrlPatterns is under 'data' per the code on line 14, are the rest of the
params siblings to 'data' or is there a namespace bug here?

[tonychun, 2015/07/06 20:11:50]

This is a bug. My unit test would have flagged this error. Thanks!

+  item.GetString("jabberId", &jid);
+  item.GetString("hostName", &name);
+  item.GetString("hostOfflineReason", &offline_reason);
+  item.GetString("publicKey", &public_key);
+
+  std::string status;
+  item.GetString("status", &status);
+  is_online = (status == "ONLINE") ? true : false;

[joedow, 2015/07/01 03:39:33]

Are there other statuses?  I'm thinking that an enum of the statuses would be
more useful than an is_online member (interested consumers can check for a
specific status such as disabled without you have to extend the struct).

[joedow, 2015/07/01 03:39:33]

"ONLINE" should be a constant in a namespace at the top of the file for the
comparison either way.

[tonychun, 2015/07/06 20:11:50]

Done.

+}
+
+ChromotingHostInfo::~ChromotingHostInfo() {
+}
+
+}  // namespace test
+}  // namespace remoting