Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 1212333005: Add a bitmap width and height size check to the PNG encoder (Closed)

Created:
5 years, 5 months ago by Noel Gordon
Modified:
5 years, 5 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add a bitmap width and height size check to the PNG encoder The width and height should be valid, but add a size check while we figure out the root cause of issue 504690. BUG=504690 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197989

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/platform/image-encoders/skia/PNGImageEncoder.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Noel Gordon
5 years, 5 months ago (2015-06-29 13:55:31 UTC) #2
Justin Novosad
On 2015/06/29 13:55:31, noel gordon wrote: lgtm
5 years, 5 months ago (2015-06-29 14:03:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212333005/1
5 years, 5 months ago (2015-06-29 14:04:06 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 14:47:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197989

Powered by Google App Engine
This is Rietveld 408576698