Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1212333002: Revert of [Telemetry] Remove adb_commands usage from android_device. (Closed)

Created:
5 years, 5 months ago by Paweł Hajdan Jr.
Modified:
5 years, 5 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Telemetry] Remove adb_commands usage from android_device. (patchset #1 id:1 of https://codereview.chromium.org/1212643002/) Reason for revert: Speculative revert, see https://code.google.com/p/chromium/issues/detail?id=504707 Original issue's description: > [Telemetry] Remove adb_commands usage from android_device. > > BUG=476709 > > Committed: https://crrev.com/fca25ba372bc2d5f8309dd9db837779b7faaffdd > Cr-Commit-Position: refs/heads/master@{#336325} TBR=jbudorick@chromium.org,nednguyen@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=476709, 504707 Committed: https://crrev.com/17fce99eb549c36e92ac2a35312aaf65803290e7 Cr-Commit-Position: refs/heads/master@{#336351}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -99 lines) Patch
M tools/telemetry/telemetry/core/platform/android_device.py View 4 chunks +32 lines, -17 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/android_device_unittest.py View 1 chunk +96 lines, -82 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Paweł Hajdan Jr.
Created Revert of [Telemetry] Remove adb_commands usage from android_device.
5 years, 5 months ago (2015-06-26 11:01:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212333002/1
5 years, 5 months ago (2015-06-26 11:02:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-26 11:02:38 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/17fce99eb549c36e92ac2a35312aaf65803290e7 Cr-Commit-Position: refs/heads/master@{#336351}
5 years, 5 months ago (2015-06-26 11:03:33 UTC) #5
Noel Gordon
5 years, 5 months ago (2015-06-26 11:27:42 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698