DevTools: [CSS] migrate setStyleSheetText to promises

Source/devtools/front_end/sdk/CSSStyleModel.js

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 539 matching lines @@
         var result = [];
         for (var frameId in frameIdToStyleSheetIds)
             result = result.concat(frameIdToStyleSheetIds[frameId]);
         return result;
     },
 
     /**
      * @param {!CSSAgent.StyleSheetId} styleSheetId
      * @param {string} newText
      * @param {boolean} majorChange
-     * @param {?function(?Protocol.Error)} userCallback
+     * @return {!Promise.<?Protocol.Error>}
      */
-    setStyleSheetText: function(styleSheetId, newText, majorChange, userCallback)
+    setStyleSheetText: function(styleSheetId, newText, majorChange)
     {
         var header = this._styleSheetIdToHeader.get(styleSheetId);
         console.assert(header);
         this._pendingCommandsMajorState.push(majorChange);
-        header.setContent(newText, callback.bind(this));
+        return header._setContentPromise(newText).then(callback.bind(this));
 
         /**
          * @param {?Protocol.Error} error
+         * @return {?Protocol.Error}
          * @this {WebInspector.CSSStyleModel}
          */
         function callback(error)
         {
             this._pendingCommandsMajorState.pop();
             if (!error && majorChange)
                 this._domModel.markUndoableState();
 
-            if (!error && userCallback)
-                userCallback(error);
+            return error;
         }
     },
 
     _undoRedoRequested: function()
     {
         this._pendingCommandsMajorState.push(true);
     },
 
     _undoRedoCompleted: function()
     {
@@ skipping 1209 matching lines @@
         {
             callback(WebInspector.ContentProvider.performSearchInContent(content, query, caseSensitive, isRegex));
         }
 
         // searchInContent should call back later.
         this.requestContent(performSearch);
     },
 
     /**
      * @param {string} newText
-     * @param {function(?Protocol.Error)} callback
+     * @return {!Promise.<?Protocol.Error>}
      */
-    setContent: function(newText, callback)
+    _setContentPromise: function(newText)
     {
         newText = this._trimSourceURL(newText);
         if (this.hasSourceURL)
             newText += "\n/*# sourceURL=" + this.sourceURL + " */";
-        this._cssModel._agent.setStyleSheetText(this.id, newText, extractProtocolError)
-            .then(callback);
+        return this._cssModel._agent.setStyleSheetText(this.id, newText, extractProtocolError);
 
         /**
          * @param {?Protocol.Error} error
+         * @return {?Protocol.Error}
          */
         function extractProtocolError(error)
         {
             return error || null;
         }
     },
 
     /**
+     * @param {string} newText
+     * @param {function(?Protocol.Error)} callback
+     */
+    setContent: function(newText, callback)
+    {
+        this._setContentPromise(newText)

[pfeldman, 2015/06/26 09:13:42]

Add fixme to remove

[lushnikov, 2015/06/26 12:33:28]

Acknowledged.

+            .catchException(null)
+            .then(callback);
+    },
+
+    /**
      * @return {boolean}
      */
     isViaInspector: function()
     {
         return this.origin === "inspector";
     }
 }
 
 /**
  * @constructor
@@ skipping 148 matching lines @@
  * @constructor
  * @param {?WebInspector.CSSStyleDeclaration} inlineStyle
  * @param {?WebInspector.CSSStyleDeclaration} attributesStyle
  */
 WebInspector.CSSStyleModel.InlineStyleResult = function(inlineStyle, attributesStyle)
 {
     this.inlineStyle = inlineStyle;
     this.attributesStyle = attributesStyle;
 }