DevTools: [CSS] migrate setStyleSheetText to promises

Source/devtools/front_end/bindings/StylesSourceMapping.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 229 matching lines @@
                 continue;
             this._unbindUISourceCode(uiSourceCode);
         }
         this._initialize();
     },
 
     /**
      * @param {!WebInspector.UISourceCode} uiSourceCode
      * @param {string} content
      * @param {boolean} majorChange
-     * @param {function(?string)} userCallback
+     * @return {!Promise<?string>}
      */
-    _setStyleContent: function(uiSourceCode, content, majorChange, userCallback)
+    _setStyleContent: function(uiSourceCode, content, majorChange)
     {
         var networkURL = this._networkMapping.networkURL(uiSourceCode);
         var styleSheetIds = this._cssModel.styleSheetIdsForURL(networkURL);
-        if (!styleSheetIds.length) {
-            userCallback("No stylesheet found: " + networkURL);
-            return;
-        }
+        if (!styleSheetIds.length)
+            return Promise.resolve(/** @type {?string} */("No stylesheet found: " + networkURL));
 
         this._isSettingContent = true;
 
         /**
-         * @param {?Protocol.Error} error
          * @this {WebInspector.StylesSourceMapping}
+         * @return {?string}
          */
-        function callback(error)
+        function callback()
         {
-            userCallback(error);

[pfeldman, 2015/06/26 09:13:42]

If there was one stylesheet, a very common case, we used to preserve the error
message.

[lushnikov, 2015/06/26 12:33:28]

Done.

             delete this._isSettingContent;
+            return null;
         }
 
-
+        var promises = [];
         for (var i = 0; i < styleSheetIds.length; ++i)
-            this._cssModel.setStyleSheetText(styleSheetIds[i], content, majorChange, i === styleSheetIds.length - 1 ? callback.bind(this) : null);
+            promises.push(this._cssModel.setStyleSheetText(styleSheetIds[i], content, majorChange));
+        return Promise.all(promises).then(callback.bind(this));
     },
 
     /**
      * @param {!WebInspector.Event} event
      */
     _styleSheetChanged: function(event)
     {
         if (this._isSettingContent)
             return;
 
@@ skipping 87 matching lines @@
     {
         if (this._isAddingRevision)
             return;
 
         this._commitThrottler.schedule(this._commitIncrementalEdit.bind(this), false);
     },
 
     /**
      * @param {!WebInspector.Throttler.FinishCallback} finishCallback
      */
     _commitIncrementalEdit: function(finishCallback)

[pfeldman, 2015/06/26 09:13:42]

Add fixme to make it a promise?

[lushnikov, 2015/06/26 12:33:28]

Acknowledged.

     {
-        this._mapping._setStyleContent(this._uiSourceCode, this._uiSourceCode.workingCopy(), this._isMajorChangePending, this._styleContentSet.bind(this, finishCallback));
+        this._mapping._setStyleContent(this._uiSourceCode, this._uiSourceCode.workingCopy(), this._isMajorChangePending)
+            .then(this._styleContentSet.bind(this))
+            .then(finishCallback)
+            .catch(/** @type {function()} */(finishCallback));
         this._isMajorChangePending = false;
     },
 
     /**
-     * @param {!WebInspector.Throttler.FinishCallback} finishCallback
      * @param {?string} error
      */
-    _styleContentSet: function(finishCallback, error)
+    _styleContentSet: function(error)
     {
         if (error)
             WebInspector.console.error(error);
-        finishCallback();
     },
 
     /**
      * @param {string} content
      */
     addRevision: function(content)
     {
         this._isAddingRevision = true;
         this._uiSourceCode.addRevision(content);
         delete this._isAddingRevision;
     },
 
     dispose: function()
     {
         this._uiSourceCode.removeEventListener(WebInspector.UISourceCode.Events.WorkingCopyCommitted, this._workingCopyCommitted, this);
         this._uiSourceCode.removeEventListener(WebInspector.UISourceCode.Events.WorkingCopyChanged, this._workingCopyChanged, this);
     }
 }