Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1553)

Unified Diff: Source/core/svg/animation/SVGSMILElement.h

Issue 1212253012: Fix virtual/override/final usage in Source/core/svg/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/animation/SVGSMILElement.h
diff --git a/Source/core/svg/animation/SVGSMILElement.h b/Source/core/svg/animation/SVGSMILElement.h
index 99a5cdba85eff3fdb7361e3e4c3dcc58437a7597..8959bc296c1829795b5d6fd60e89e8953b809f46 100644
--- a/Source/core/svg/animation/SVGSMILElement.h
+++ b/Source/core/svg/animation/SVGSMILElement.h
@@ -48,12 +48,12 @@ class CORE_EXPORT SVGSMILElement : public SVGElement, public SVGTests {
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(SVGSMILElement);
public:
SVGSMILElement(const QualifiedName&, Document&);
- virtual ~SVGSMILElement();
+ ~SVGSMILElement() override;
- virtual void parseAttribute(const QualifiedName&, const AtomicString&) override;
- virtual void svgAttributeChanged(const QualifiedName&) override;
- virtual InsertionNotificationRequest insertedInto(ContainerNode*) override;
- virtual void removedFrom(ContainerNode*) override;
+ void parseAttribute(const QualifiedName&, const AtomicString&) override;
+ void svgAttributeChanged(const QualifiedName&) override;
+ InsertionNotificationRequest insertedInto(ContainerNode*) override;
+ void removedFrom(ContainerNode*) override;
virtual bool hasValidAttributeType() = 0;
virtual bool hasValidAttributeName();
@@ -136,7 +136,7 @@ protected:
void unscheduleIfScheduled();
private:
- virtual void buildPendingResource() override;
+ void buildPendingResource() override;
void clearResourceAndEventBaseReferences();
void clearConditions();
@@ -144,7 +144,7 @@ private:
void endedActiveInterval();
virtual void updateAnimation(float percent, unsigned repeat, SVGSMILElement* resultElement) = 0;
- virtual bool layoutObjectIsNeeded(const ComputedStyle&) override { return false; }
+ bool layoutObjectIsNeeded(const ComputedStyle&) override { return false; }
enum BeginOrEnd {
Begin,

Powered by Google App Engine
This is Rietveld 408576698