Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1680)

Unified Diff: Source/core/svg/SVGUseElement.h

Issue 1212253012: Fix virtual/override/final usage in Source/core/svg/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/SVGUseElement.h
diff --git a/Source/core/svg/SVGUseElement.h b/Source/core/svg/SVGUseElement.h
index dde6fcbb0d50efbb97560efd13e75b5ff28fc8cb..647b59ee3952ae1d04e8bd95e2bcbc76cd8d5a1b 100644
--- a/Source/core/svg/SVGUseElement.h
+++ b/Source/core/svg/SVGUseElement.h
@@ -40,7 +40,7 @@ class SVGUseElement final : public SVGGraphicsElement,
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(SVGUseElement);
public:
static PassRefPtrWillBeRawPtr<SVGUseElement> create(Document&);
- virtual ~SVGUseElement();
+ ~SVGUseElement() override;
void invalidateShadowTree();
@@ -53,7 +53,7 @@ public:
SVGAnimatedLength* width() const { return m_width.get(); }
SVGAnimatedLength* height() const { return m_height.get(); }
- virtual void buildPendingResource() override;
+ void buildPendingResource() override;
void dispatchPendingEvent(SVGUseEventSender*);
void toClipPath(Path&) const;
@@ -63,26 +63,26 @@ public:
private:
explicit SVGUseElement(Document&);
- virtual bool isPresentationAttribute(const QualifiedName&) const override;
- virtual void collectStyleForPresentationAttribute(const QualifiedName&, const AtomicString&, MutableStylePropertySet*) override;
- virtual bool isPresentationAttributeWithSVGDOM(const QualifiedName&) const override;
+ bool isPresentationAttribute(const QualifiedName&) const override;
+ void collectStyleForPresentationAttribute(const QualifiedName&, const AtomicString&, MutableStylePropertySet*) override;
+ bool isPresentationAttributeWithSVGDOM(const QualifiedName&) const override;
- virtual bool isStructurallyExternal() const override { return !hrefString().isNull() && isExternalURIReference(hrefString(), document()); }
+ bool isStructurallyExternal() const override { return !hrefString().isNull() && isExternalURIReference(hrefString(), document()); }
- virtual InsertionNotificationRequest insertedInto(ContainerNode*) override;
- virtual void removedFrom(ContainerNode*) override;
+ InsertionNotificationRequest insertedInto(ContainerNode*) override;
+ void removedFrom(ContainerNode*) override;
- virtual void svgAttributeChanged(const QualifiedName&) override;
+ void svgAttributeChanged(const QualifiedName&) override;
- virtual LayoutObject* createLayoutObject(const ComputedStyle&) override;
+ LayoutObject* createLayoutObject(const ComputedStyle&) override;
void clearResourceReferences();
void buildShadowAndInstanceTree(SVGElement* target);
void scheduleShadowTreeRecreation();
- virtual bool haveLoadedRequiredResources() override { return !isStructurallyExternal() || m_haveFiredLoadEvent; }
+ bool haveLoadedRequiredResources() override { return !isStructurallyExternal() || m_haveFiredLoadEvent; }
- virtual bool selfHasRelativeLengths() const override;
+ bool selfHasRelativeLengths() const override;
// Instance tree handling
bool buildShadowTree(SVGElement* target, SVGElement* targetInstance, bool foundUse);
@@ -97,7 +97,7 @@ private:
bool resourceIsStillLoading();
Document* externalDocument() const;
bool instanceTreeIsLoading(SVGElement*);
- virtual void notifyFinished(Resource*) override;
+ void notifyFinished(Resource*) override;
TreeScope* referencedScope() const;
void setDocumentResource(ResourcePtr<DocumentResource>);

Powered by Google App Engine
This is Rietveld 408576698