Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1469)

Unified Diff: Source/core/svg/SVGScriptElement.h

Issue 1212253012: Fix virtual/override/final usage in Source/core/svg/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/SVGScriptElement.h
diff --git a/Source/core/svg/SVGScriptElement.h b/Source/core/svg/SVGScriptElement.h
index 8ba707581743197f84cef98c40a7098570cf26d7..1f8a64bb396d25eac841d2c0375a5ea1a3720352 100644
--- a/Source/core/svg/SVGScriptElement.h
+++ b/Source/core/svg/SVGScriptElement.h
@@ -45,7 +45,7 @@ public:
ScriptLoader* loader() const { return m_loader.get(); }
#if ENABLE(ASSERT)
- virtual bool isAnimatableAttribute(const QualifiedName&) const override;
+ bool isAnimatableAttribute(const QualifiedName&) const override;
#endif
DECLARE_VIRTUAL_TRACE();
@@ -53,33 +53,33 @@ public:
private:
SVGScriptElement(Document&, bool wasInsertedByParser, bool alreadyStarted);
- virtual void parseAttribute(const QualifiedName&, const AtomicString&) override;
- virtual InsertionNotificationRequest insertedInto(ContainerNode*) override;
- virtual void didNotifySubtreeInsertionsToDocument() override;
- virtual void childrenChanged(const ChildrenChange&) override;
- virtual void didMoveToNewDocument(Document& oldDocument) override;
-
- virtual void svgAttributeChanged(const QualifiedName&) override;
- virtual bool isURLAttribute(const Attribute&) const override;
- virtual bool isStructurallyExternal() const override { return hasSourceAttribute(); }
- virtual void finishParsingChildren() override;
-
- virtual bool haveLoadedRequiredResources() override;
-
- virtual String sourceAttributeValue() const override;
- virtual String charsetAttributeValue() const override;
- virtual String typeAttributeValue() const override;
- virtual String languageAttributeValue() const override;
- virtual String forAttributeValue() const override;
- virtual String eventAttributeValue() const override;
- virtual bool asyncAttributeValue() const override;
- virtual bool deferAttributeValue() const override;
- virtual bool hasSourceAttribute() const override;
-
- virtual void dispatchLoadEvent() override;
-
- virtual PassRefPtrWillBeRawPtr<Element> cloneElementWithoutAttributesAndChildren() override;
- virtual bool layoutObjectIsNeeded(const ComputedStyle&) override { return false; }
+ void parseAttribute(const QualifiedName&, const AtomicString&) override;
+ InsertionNotificationRequest insertedInto(ContainerNode*) override;
+ void didNotifySubtreeInsertionsToDocument() override;
+ void childrenChanged(const ChildrenChange&) override;
+ void didMoveToNewDocument(Document& oldDocument) override;
+
+ void svgAttributeChanged(const QualifiedName&) override;
+ bool isURLAttribute(const Attribute&) const override;
+ bool isStructurallyExternal() const override { return hasSourceAttribute(); }
+ void finishParsingChildren() override;
+
+ bool haveLoadedRequiredResources() override;
+
+ String sourceAttributeValue() const override;
+ String charsetAttributeValue() const override;
+ String typeAttributeValue() const override;
+ String languageAttributeValue() const override;
+ String forAttributeValue() const override;
+ String eventAttributeValue() const override;
+ bool asyncAttributeValue() const override;
+ bool deferAttributeValue() const override;
+ bool hasSourceAttribute() const override;
+
+ void dispatchLoadEvent() override;
+
+ PassRefPtrWillBeRawPtr<Element> cloneElementWithoutAttributesAndChildren() override;
+ bool layoutObjectIsNeeded(const ComputedStyle&) override { return false; }
OwnPtrWillBeMember<ScriptLoader> m_loader;
};

Powered by Google App Engine
This is Rietveld 408576698