Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1160)

Unified Diff: Source/core/svg/SVGNumber.h

Issue 1212253012: Fix virtual/override/final usage in Source/core/svg/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/SVGNumber.h
diff --git a/Source/core/svg/SVGNumber.h b/Source/core/svg/SVGNumber.h
index ebae96ba52865e2704f8dd24d97da910a28821d4..19bbf8d993a08091eeb805190290cefbe1d7aab8 100644
--- a/Source/core/svg/SVGNumber.h
+++ b/Source/core/svg/SVGNumber.h
@@ -54,12 +54,12 @@ public:
float value() const { return m_value; }
void setValue(float value) { m_value = value; }
- virtual String valueAsString() const override;
+ String valueAsString() const override;
virtual void setValueAsString(const String&, ExceptionState&);
- virtual void add(PassRefPtrWillBeRawPtr<SVGPropertyBase>, SVGElement*) override;
- virtual void calculateAnimatedValue(SVGAnimationElement*, float percentage, unsigned repeatCount, PassRefPtrWillBeRawPtr<SVGPropertyBase> from, PassRefPtrWillBeRawPtr<SVGPropertyBase> to, PassRefPtrWillBeRawPtr<SVGPropertyBase> toAtEndOfDurationValue, SVGElement* contextElement) override;
- virtual float calculateDistance(PassRefPtrWillBeRawPtr<SVGPropertyBase> to, SVGElement* contextElement) override;
+ void add(PassRefPtrWillBeRawPtr<SVGPropertyBase>, SVGElement*) override;
+ void calculateAnimatedValue(SVGAnimationElement*, float percentage, unsigned repeatCount, PassRefPtrWillBeRawPtr<SVGPropertyBase> from, PassRefPtrWillBeRawPtr<SVGPropertyBase> to, PassRefPtrWillBeRawPtr<SVGPropertyBase> toAtEndOfDurationValue, SVGElement* contextElement) override;
+ float calculateDistance(PassRefPtrWillBeRawPtr<SVGPropertyBase> to, SVGElement* contextElement) override;
static AnimatedPropertyType classType() { return AnimatedNumber; }
@@ -90,8 +90,8 @@ public:
return adoptRefWillBeNoop(new SVGNumberAcceptPercentage(value));
}
- virtual PassRefPtrWillBeRawPtr<SVGNumber> clone() const override;
- virtual void setValueAsString(const String&, ExceptionState&) override;
+ PassRefPtrWillBeRawPtr<SVGNumber> clone() const override;
+ void setValueAsString(const String&, ExceptionState&) override;
private:
explicit SVGNumberAcceptPercentage(float);

Powered by Google App Engine
This is Rietveld 408576698