Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1377)

Unified Diff: Source/core/svg/SVGGraphicsElement.h

Issue 1212253012: Fix virtual/override/final usage in Source/core/svg/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/SVGGraphicsElement.h
diff --git a/Source/core/svg/SVGGraphicsElement.h b/Source/core/svg/SVGGraphicsElement.h
index a1cff5cb174606aa82167933f55cbecb2c10cf05..f97262378cdfb5cc5b187e21faa19e2f7189618d 100644
--- a/Source/core/svg/SVGGraphicsElement.h
+++ b/Source/core/svg/SVGGraphicsElement.h
@@ -39,7 +39,7 @@ class CORE_EXPORT SVGGraphicsElement : public SVGElement, public SVGTests {
DEFINE_WRAPPERTYPEINFO();
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(SVGGraphicsElement);
public:
- virtual ~SVGGraphicsElement();
+ ~SVGGraphicsElement() override;
enum StyleUpdateStrategy { AllowStyleUpdate, DisallowStyleUpdate };
@@ -53,15 +53,15 @@ public:
SVGElement* nearestViewportElement() const;
SVGElement* farthestViewportElement() const;
- virtual AffineTransform localCoordinateSpaceTransform(SVGElement::CTMScope) const override { return calculateAnimatedLocalTransform(); }
+ AffineTransform localCoordinateSpaceTransform(SVGElement::CTMScope) const override { return calculateAnimatedLocalTransform(); }
bool hasAnimatedLocalTransform() const;
AffineTransform calculateAnimatedLocalTransform() const;
- virtual AffineTransform* animateMotionTransform() override;
+ AffineTransform* animateMotionTransform() override;
virtual FloatRect getBBox();
PassRefPtrWillBeRawPtr<SVGRectTearOff> getBBoxFromJavascript();
- virtual bool isValid() const override final { return SVGTests::isValid(document()); }
+ bool isValid() const final { return SVGTests::isValid(document()); }
SVGAnimatedTransformList* transform() { return m_transform.get(); }
const SVGAnimatedTransformList* transform() const { return m_transform.get(); }
@@ -74,14 +74,14 @@ public:
protected:
SVGGraphicsElement(const QualifiedName&, Document&, ConstructionType = CreateSVGElement);
- virtual bool supportsFocus() const override { return Element::supportsFocus() || hasFocusEventListeners(); }
+ bool supportsFocus() const override { return Element::supportsFocus() || hasFocusEventListeners(); }
- virtual void svgAttributeChanged(const QualifiedName&) override;
+ void svgAttributeChanged(const QualifiedName&) override;
RefPtrWillBeMember<SVGAnimatedTransformList> m_transform;
private:
- virtual bool isSVGGraphicsElement() const override final { return true; }
+ bool isSVGGraphicsElement() const final { return true; }
};
inline bool isSVGGraphicsElement(const SVGElement& element)

Powered by Google App Engine
This is Rietveld 408576698