Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1174)

Unified Diff: Source/core/svg/SVGEnumeration.h

Issue 1212253012: Fix virtual/override/final usage in Source/core/svg/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/SVGEnumeration.h
diff --git a/Source/core/svg/SVGEnumeration.h b/Source/core/svg/SVGEnumeration.h
index 2f08aa6e6bec650bbaf307b0b60ccf19fdfcb6f3..854d14bc1e4c591d7066527a1d27bb4d7737c1ee 100644
--- a/Source/core/svg/SVGEnumeration.h
+++ b/Source/core/svg/SVGEnumeration.h
@@ -46,21 +46,21 @@ public:
typedef void TearOffType;
typedef unsigned short PrimitiveType;
- virtual ~SVGEnumerationBase();
+ ~SVGEnumerationBase() override;
unsigned short value() const { return m_value <= maxExposedEnumValue() ? m_value : 0; }
void setValue(unsigned short, ExceptionState&);
// SVGPropertyBase:
virtual PassRefPtrWillBeRawPtr<SVGEnumerationBase> clone() const = 0;
- virtual PassRefPtrWillBeRawPtr<SVGPropertyBase> cloneForAnimation(const String&) const override;
+ PassRefPtrWillBeRawPtr<SVGPropertyBase> cloneForAnimation(const String&) const override;
- virtual String valueAsString() const override;
+ String valueAsString() const override;
void setValueAsString(const String&, ExceptionState&);
- virtual void add(PassRefPtrWillBeRawPtr<SVGPropertyBase>, SVGElement*) override;
- virtual void calculateAnimatedValue(SVGAnimationElement*, float percentage, unsigned repeatCount, PassRefPtrWillBeRawPtr<SVGPropertyBase> from, PassRefPtrWillBeRawPtr<SVGPropertyBase> to, PassRefPtrWillBeRawPtr<SVGPropertyBase> toAtEndOfDurationValue, SVGElement*) override;
- virtual float calculateDistance(PassRefPtrWillBeRawPtr<SVGPropertyBase> to, SVGElement*) override;
+ void add(PassRefPtrWillBeRawPtr<SVGPropertyBase>, SVGElement*) override;
+ void calculateAnimatedValue(SVGAnimationElement*, float percentage, unsigned repeatCount, PassRefPtrWillBeRawPtr<SVGPropertyBase> from, PassRefPtrWillBeRawPtr<SVGPropertyBase> to, PassRefPtrWillBeRawPtr<SVGPropertyBase> toAtEndOfDurationValue, SVGElement*) override;
+ float calculateDistance(PassRefPtrWillBeRawPtr<SVGPropertyBase> to, SVGElement*) override;
static AnimatedPropertyType classType() { return AnimatedEnumeration; }
@@ -108,11 +108,9 @@ public:
return adoptRefWillBeNoop(new SVGEnumeration<Enum>(newValue));
}
- virtual ~SVGEnumeration()
- {
- }
+ ~SVGEnumeration() override {}
- virtual PassRefPtrWillBeRawPtr<SVGEnumerationBase> clone() const override
+ PassRefPtrWillBeRawPtr<SVGEnumerationBase> clone() const override
{
return create(enumValue());
}

Powered by Google App Engine
This is Rietveld 408576698