Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9083)

Unified Diff: Source/core/svg/SVGAnimationElement.h

Issue 1212253012: Fix virtual/override/final usage in Source/core/svg/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/SVGAnimationElement.h
diff --git a/Source/core/svg/SVGAnimationElement.h b/Source/core/svg/SVGAnimationElement.h
index 35f4130b362f5cecb9a6ee4fad86570f43ebd54b..6b2ffb8a4c54261fa3106bd17c556187606211c8 100644
--- a/Source/core/svg/SVGAnimationElement.h
+++ b/Source/core/svg/SVGAnimationElement.h
@@ -140,8 +140,8 @@ protected:
void computeCSSPropertyValue(SVGElement*, CSSPropertyID, String& value);
void determinePropertyValueTypes(const String& from, const String& to);
- virtual void parseAttribute(const QualifiedName&, const AtomicString&) override;
- virtual void svgAttributeChanged(const QualifiedName&) override;
+ void parseAttribute(const QualifiedName&, const AtomicString&) override;
+ void svgAttributeChanged(const QualifiedName&) override;
enum AttributeType {
AttributeTypeCSS,
@@ -155,14 +155,14 @@ protected:
String fromValue() const;
// from SVGSMILElement
- virtual void startedActiveInterval() override;
- virtual void updateAnimation(float percent, unsigned repeat, SVGSMILElement* resultElement) override;
+ void startedActiveInterval() override;
+ void updateAnimation(float percent, unsigned repeat, SVGSMILElement* resultElement) override;
AnimatedPropertyValueType m_fromPropertyValueType;
AnimatedPropertyValueType m_toPropertyValueType;
- virtual void setTargetElement(SVGElement*) override;
- virtual void setAttributeName(const QualifiedName&) override;
+ void setTargetElement(SVGElement*) override;
+ void setAttributeName(const QualifiedName&) override;
bool hasInvalidCSSAttributeType() const { return m_hasInvalidCSSAttributeType; }
@@ -178,9 +178,9 @@ protected:
static bool parseValues(const String&, Vector<String>& result);
private:
- virtual bool isValid() const override final { return SVGTests::isValid(document()); }
+ bool isValid() const final { return SVGTests::isValid(document()); }
- virtual void animationAttributeChanged() override;
+ void animationAttributeChanged() override;
void setAttributeType(const AtomicString&);
void checkInvalidCSSAttributeType();

Powered by Google App Engine
This is Rietveld 408576698