Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1083)

Unified Diff: Source/core/svg/SVGAnimateElement.h

Issue 1212253012: Fix virtual/override/final usage in Source/core/svg/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/SVGAnimateElement.h
diff --git a/Source/core/svg/SVGAnimateElement.h b/Source/core/svg/SVGAnimateElement.h
index 6389ea25e3f9a86fe8c7d4da46b5fea634cffe4c..296b6edad045abbeaa5d1e16fa2bf09b6694bed9 100644
--- a/Source/core/svg/SVGAnimateElement.h
+++ b/Source/core/svg/SVGAnimateElement.h
@@ -39,11 +39,11 @@ class CORE_EXPORT SVGAnimateElement : public SVGAnimationElement {
DEFINE_WRAPPERTYPEINFO();
public:
static PassRefPtrWillBeRawPtr<SVGAnimateElement> create(Document&);
- virtual ~SVGAnimateElement();
+ ~SVGAnimateElement() override;
DECLARE_VIRTUAL_TRACE();
- virtual bool isSVGAnimationAttributeSettingJavaScriptURL(const Attribute&) const override;
+ bool isSVGAnimationAttributeSettingJavaScriptURL(const Attribute&) const override;
AnimatedPropertyType animatedPropertyType();
bool animatedPropertyTypeSupportsAddition();
@@ -53,26 +53,26 @@ public:
protected:
SVGAnimateElement(const QualifiedName&, Document&);
- virtual void resetAnimatedType() override final;
- virtual void clearAnimatedType() override final;
+ void resetAnimatedType() final;
+ void clearAnimatedType() final;
- virtual bool calculateToAtEndOfDurationValue(const String& toAtEndOfDurationString) override final;
- virtual bool calculateFromAndToValues(const String& fromString, const String& toString) override final;
- virtual bool calculateFromAndByValues(const String& fromString, const String& byString) override final;
- virtual void calculateAnimatedValue(float percentage, unsigned repeatCount, SVGSMILElement* resultElement) override final;
- virtual void applyResultsToTarget() override final;
- virtual float calculateDistance(const String& fromString, const String& toString) override final;
- virtual bool isAdditive() override final;
+ bool calculateToAtEndOfDurationValue(const String& toAtEndOfDurationString) final;
+ bool calculateFromAndToValues(const String& fromString, const String& toString) final;
+ bool calculateFromAndByValues(const String& fromString, const String& byString) final;
+ void calculateAnimatedValue(float percentage, unsigned repeatCount, SVGSMILElement* resultElement) final;
+ void applyResultsToTarget() final;
+ float calculateDistance(const String& fromString, const String& toString) final;
+ bool isAdditive() final;
- virtual void setTargetElement(SVGElement*) override final;
- virtual void setAttributeName(const QualifiedName&) override final;
+ void setTargetElement(SVGElement*) final;
+ void setAttributeName(const QualifiedName&) final;
FRIEND_TEST_ALL_PREFIXES(UnsafeSVGAttributeSanitizationTest, stringsShouldNotSupportAddition);
private:
void resetAnimatedPropertyType();
- virtual bool hasValidAttributeType() override;
+ bool hasValidAttributeType() override;
RefPtrWillBeMember<SVGPropertyBase> m_fromProperty;
RefPtrWillBeMember<SVGPropertyBase> m_toProperty;

Powered by Google App Engine
This is Rietveld 408576698