Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Side by Side Diff: Source/core/svg/graphics/filters/SVGFEImage.h

Issue 1212253012: Fix virtual/override/final usage in Source/core/svg/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2006, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org>
4 * Copyright (C) 2005 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2005 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2010 Dirk Schulze <krit@webkit.org> 5 * Copyright (C) 2010 Dirk Schulze <krit@webkit.org>
6 * Copyright (C) 2013 Google Inc. All rights reserved. 6 * Copyright (C) 2013 Google Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 20 matching lines...) Expand all
31 namespace blink { 31 namespace blink {
32 32
33 class Image; 33 class Image;
34 class LayoutObject; 34 class LayoutObject;
35 35
36 class FEImage final : public FilterEffect { 36 class FEImage final : public FilterEffect {
37 public: 37 public:
38 static PassRefPtrWillBeRawPtr<FEImage> createWithImage(Filter*, PassRefPtr<I mage>, PassRefPtrWillBeRawPtr<SVGPreserveAspectRatio>); 38 static PassRefPtrWillBeRawPtr<FEImage> createWithImage(Filter*, PassRefPtr<I mage>, PassRefPtrWillBeRawPtr<SVGPreserveAspectRatio>);
39 static PassRefPtrWillBeRawPtr<FEImage> createWithIRIReference(Filter*, TreeS cope&, const String&, PassRefPtrWillBeRawPtr<SVGPreserveAspectRatio>); 39 static PassRefPtrWillBeRawPtr<FEImage> createWithIRIReference(Filter*, TreeS cope&, const String&, PassRefPtrWillBeRawPtr<SVGPreserveAspectRatio>);
40 40
41 virtual FloatRect determineAbsolutePaintRect(const FloatRect& requestedRect) override; 41 FloatRect determineAbsolutePaintRect(const FloatRect& requestedRect) overrid e;
42 42
43 virtual FilterEffectType filterEffectType() const override { return FilterEf fectTypeImage; } 43 FilterEffectType filterEffectType() const override { return FilterEffectType Image; }
44 44
45 // feImage does not perform color interpolation of any kind, so doesn't 45 // feImage does not perform color interpolation of any kind, so doesn't
46 // depend on the value of color-interpolation-filters. 46 // depend on the value of color-interpolation-filters.
47 virtual void setOperatingColorSpace(ColorSpace) override { } 47 void setOperatingColorSpace(ColorSpace) override { }
48 48
49 virtual TextStream& externalRepresentation(TextStream&, int indention) const override; 49 TextStream& externalRepresentation(TextStream&, int indention) const overrid e;
50 virtual PassRefPtr<SkImageFilter> createImageFilter(SkiaImageFilterBuilder*) override; 50 PassRefPtr<SkImageFilter> createImageFilter(SkiaImageFilterBuilder*) overrid e;
51 51
52 DECLARE_VIRTUAL_TRACE(); 52 DECLARE_VIRTUAL_TRACE();
53 53
54 private: 54 private:
55 virtual ~FEImage() { } 55 ~FEImage() override {}
56 FEImage(Filter*, PassRefPtr<Image>, PassRefPtrWillBeRawPtr<SVGPreserveAspect Ratio>); 56 FEImage(Filter*, PassRefPtr<Image>, PassRefPtrWillBeRawPtr<SVGPreserveAspect Ratio>);
57 FEImage(Filter*, TreeScope&, const String&, PassRefPtrWillBeRawPtr<SVGPreser veAspectRatio>); 57 FEImage(Filter*, TreeScope&, const String&, PassRefPtrWillBeRawPtr<SVGPreser veAspectRatio>);
58 LayoutObject* referencedLayoutObject() const; 58 LayoutObject* referencedLayoutObject() const;
59 59
60 PassRefPtr<SkImageFilter> createImageFilterForLayoutObject(LayoutObject&, Sk iaImageFilterBuilder*); 60 PassRefPtr<SkImageFilter> createImageFilterForLayoutObject(LayoutObject&, Sk iaImageFilterBuilder*);
61 61
62 RefPtr<Image> m_image; 62 RefPtr<Image> m_image;
63 63
64 // m_treeScope will never be a dangling reference. See https://bugs.webkit.o rg/show_bug.cgi?id=99243 64 // m_treeScope will never be a dangling reference. See https://bugs.webkit.o rg/show_bug.cgi?id=99243
65 // FIXME: Oilpan: turn into a (weak) member? 65 // FIXME: Oilpan: turn into a (weak) member?
66 TreeScope* m_treeScope; 66 TreeScope* m_treeScope;
67 String m_href; 67 String m_href;
68 RefPtrWillBeMember<SVGPreserveAspectRatio> m_preserveAspectRatio; 68 RefPtrWillBeMember<SVGPreserveAspectRatio> m_preserveAspectRatio;
69 }; 69 };
70 70
71 } // namespace blink 71 } // namespace blink
72 72
73 #endif // SVGFEImage_h 73 #endif // SVGFEImage_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698