[CodeHealth] Use PositionStrategy<Strategy> instead of using ::PositionType

Use PositionStrategy<Strategy> instead of using ::PositionType

BUG=504739
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198035

[yoichio, 2015-06-26 07:56:33]

Patchset #1 (id:1) has been deleted

[yoichio, 2015-06-26 07:59:35]

yoichio@chromium.org changed reviewers:
+ yosin@chromium.org

[yosin_UTC9, 2015-06-26 08:36:05]

On 2015/06/26 07:59:36, yoichio wrote:

Could you rebase?

[yosin_UTC9, 2015-06-26 08:39:24]

https://codereview.chromium.org/1212253002/diff/20001/Source/core/dom/Positio...
File Source/core/dom/Position.cpp (right):

https://codereview.chromium.org/1212253002/diff/20001/Source/core/dom/Positio...
Source/core/dom/Position.cpp:233: typename PositionAlgorithm<Strategy>
PositionAlgorithm<Strategy>::parentAnchoredEquivalent() const
We don't need to have |typename|.
Apply this comment rest of file.

https://codereview.chromium.org/1212253002/diff/20001/Source/core/dom/Position.h
File Source/core/dom/Position.h (right):

https://codereview.chromium.org/1212253002/diff/20001/Source/core/dom/Positio...
Source/core/dom/Position.h:273: typename PositionAlgorithm<Strategy>
PositionAlgorithm<Strategy>::createLegacyEditingPosition(PassRefPtrWillBeRawPtr<Node>
node, int offset)
We don't need to have |typename|.
Apply this comments rest of this file.

[yoichio, 2015-06-29 06:00:34]

https://codereview.chromium.org/1212253002/diff/20001/Source/core/dom/Positio...
File Source/core/dom/Position.cpp (right):

https://codereview.chromium.org/1212253002/diff/20001/Source/core/dom/Positio...
Source/core/dom/Position.cpp:233: typename PositionAlgorithm<Strategy>
PositionAlgorithm<Strategy>::parentAnchoredEquivalent() const
On 2015/06/26 08:39:24, Yosi_UTC9 wrote:
> We don't need to have |typename|.
> Apply this comment rest of file.

Done.

https://codereview.chromium.org/1212253002/diff/20001/Source/core/dom/Position.h
File Source/core/dom/Position.h (right):

https://codereview.chromium.org/1212253002/diff/20001/Source/core/dom/Positio...
Source/core/dom/Position.h:273: typename PositionAlgorithm<Strategy>
PositionAlgorithm<Strategy>::createLegacyEditingPosition(PassRefPtrWillBeRawPtr<Node>
node, int offset)
On 2015/06/26 08:39:24, Yosi_UTC9 wrote:
> We don't need to have |typename|.
> Apply this comments rest of this file.

Done.

[yosin_UTC9, 2015-06-29 07:07:14]

lgtm

[yosin_UTC9, 2015-06-29 07:07:56]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2015-06-29 07:08:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1212253002/40001

[commit-bot: I haz the power, 2015-06-29 07:13:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-29 07:13:49]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/3...)

[yoichio, 2015-06-29 09:01:26]

yoichio@chromium.org changed reviewers:
+ hayato@chromium.org

[yoichio, 2015-06-29 09:01:26]

Add a core/dom owner. PTAL.

[hayato, 2015-06-30 05:12:01]

lgtm

[yoichio, 2015-06-30 05:25:40]

The CQ bit was checked by yoichio@chromium.org

[commit-bot: I haz the power, 2015-06-30 05:25:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1212253002/40001

[commit-bot: I haz the power, 2015-06-30 05:29:57]

Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198035