Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1212243003: Enable AllowTargetedNavigationsAfterSwap and DisownOpener. (Closed)

Created:
5 years, 5 months ago by nasko
Modified:
5 years, 5 months ago
Reviewers:
jam, alexmos
CC:
chromium-reviews, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable AllowTargetedNavigationsAfterSwap and DisownOpener. A few fixes have now landed making these two test pass with --site-per-process. TBR=jam@chromium.org BUG=496923, 357747 Committed: https://crrev.com/d13d3940db59fd6fc93430acad64d081812e575d Cr-Commit-Position: refs/heads/master@{#337018}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M testing/buildbot/chromium.fyi.json View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
nasko
Hey Alex, These two tests now pass with --site-per-process, so we should enable them on ...
5 years, 5 months ago (2015-07-01 11:11:35 UTC) #2
alexmos
LGTM. Note that linux_site_isolation is red, but because of a flaky WebView test and not ...
5 years, 5 months ago (2015-07-01 14:07:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212243003/1
5 years, 5 months ago (2015-07-01 14:07:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-01 14:09:54 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 14:10:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d13d3940db59fd6fc93430acad64d081812e575d
Cr-Commit-Position: refs/heads/master@{#337018}

Powered by Google App Engine
This is Rietveld 408576698