Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 121223003: DevTools: Move usedHeapSize from TimelineEvent into counters. (Closed)

Created:
6 years, 12 months ago by alph
Modified:
6 years, 12 months ago
Reviewers:
caseq, yurys
CC:
blink-reviews, shans, apavlov+blink_chromium.org, rjwright, Steve Block, dino_apple.com, caseq+blink_chromium.org, aandrey+blink_chromium.org, alancutter (OOO until 2018), pfeldman+blink_chromium.org, yurys+blink_chromium.org, dstockwell, Timothy Loh, devtools-reviews_chromium.org, Eric Willigers, loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, darktears, alph+blink_chromium.org, vsevik+blink_chromium.org, Mike Lawther (Google)
Visibility:
Public.

Description

DevTools: Move usedHeapSize from TimelineEvent into counters. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164341

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -101 lines) Patch
M LayoutTests/http/tests/inspector/timeline-test.js View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/timeline-xhr-event-expected.txt View 4 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/inspector/timeline-xhr-response-type-blob-event-expected.txt View 4 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/inspector/websocket/timeline-websocket-event-expected.txt View 4 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/inspector/styles/styles-should-not-force-sync-style-recalc-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/timeline/timeline-animation-frame-expected.txt View 3 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-decode-resize-expected.txt View 14 chunks +0 lines, -14 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-dom-content-loaded-event-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/timeline/timeline-event-dispatch-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/timeline/timeline-injected-script-eval-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-layout-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-load.html View 2 chunks +10 lines, -10 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-load-event-expected.txt View 4 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-mark-timeline-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/timeline/timeline-network-resource-expected.txt View 3 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-paint-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/timeline/timeline-parse-html-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-recalculate-styles-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/timeline/timeline-script-tag-1-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/timeline/timeline-script-tag-2-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/timeline/timeline-time-stamp-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-timer-expected.txt View 11 chunks +0 lines, -11 lines 0 comments Download
M LayoutTests/virtual/deferred/inspector/timeline/timeline-decode-resize-expected.txt View 8 chunks +0 lines, -8 lines 0 comments Download
M LayoutTests/virtual/implsidepainting/inspector/timeline/timeline-decode-resize-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorTimelineAgent.cpp View 1 chunk +6 lines, -5 lines 0 comments Download
M Source/devtools/front_end/TimelineMemoryOverview.js View 2 chunks +6 lines, -4 lines 0 comments Download
M Source/devtools/front_end/TimelinePresentationModel.js View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/devtools/protocol.json View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
alph
Yury, could you please take a look.
6 years, 12 months ago (2013-12-26 11:40:19 UTC) #1
yurys
You need to make sure that it doesn't break telementry and endure tests.
6 years, 12 months ago (2013-12-26 11:43:00 UTC) #2
yurys
LGTM, provided that it doesn't break Chrome Endure tests.
6 years, 12 months ago (2013-12-26 11:51:26 UTC) #3
alph
On 2013/12/26 11:51:26, yurys wrote: > LGTM, provided that it doesn't break Chrome Endure tests. ...
6 years, 12 months ago (2013-12-26 11:59:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/121223003/1
6 years, 12 months ago (2013-12-26 12:00:01 UTC) #5
commit-bot: I haz the power
6 years, 12 months ago (2013-12-26 12:49:27 UTC) #6
Message was sent while issue was closed. 
Change committed as 164341

Powered by Google App Engine
This is Rietveld 408576698