Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2833)

Unified Diff: cc/debug/debug_colors.cc

Issue 121223002: DevTools: Change paint rectangles' colors in compositor to shades of green. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Made colors closer in hue space. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/debug/debug_colors.cc
diff --git a/cc/debug/debug_colors.cc b/cc/debug/debug_colors.cc
index 4e3f32e317d71b87a7b0bd74200454a7a459556a..92dabc79096e9870c1ee475cd5e22fba68b51a79 100644
--- a/cc/debug/debug_colors.cc
+++ b/cc/debug/debug_colors.cc
@@ -2,12 +2,17 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "base/macros.h"
+
#include "cc/debug/debug_colors.h"
#include "cc/trees/layer_tree_impl.h"
namespace cc {
+static const int kPaintRectColors[][3] = {{0, 155, 0}, {0, 195, 0},
danakj 2014/02/10 16:11:12 nit: can you move this down just above the 2 metho
+ {0, 235, 0}};
+
static float Scale(float width, const LayerTreeImpl* tree_impl) {
return width * (tree_impl ? tree_impl->device_scale_factor() : 1);
}
@@ -171,13 +176,21 @@ SkColor DebugColors::EvictedTileCheckerboardColor() {
// ======= Debug rect colors =======
-// Paint rects in red.
-SkColor DebugColors::PaintRectBorderColor() {
- return SkColorSetARGB(255, 255, 0, 0);
+// Paint rects in shades of green.
+SkColor DebugColors::PaintRectBorderColor(int color_index) {
+ int real_index = color_index % arraysize(kPaintRectColors);
+ return SkColorSetARGB(255,
+ kPaintRectColors[real_index][0],
+ kPaintRectColors[real_index][1],
+ kPaintRectColors[real_index][2]);
}
int DebugColors::PaintRectBorderWidth() { return 2; }
-SkColor DebugColors::PaintRectFillColor() {
- return SkColorSetARGB(30, 255, 0, 0);
+SkColor DebugColors::PaintRectFillColor(int color_index) {
+ int real_index = color_index % arraysize(kPaintRectColors);
+ return SkColorSetARGB(30,
+ kPaintRectColors[real_index][0],
+ kPaintRectColors[real_index][1],
+ kPaintRectColors[real_index][2]);
}
// Property-changed rects in blue.

Powered by Google App Engine
This is Rietveld 408576698