DevTools: Change paint rectangles' colors in compositor to shades of green.

cc/debug/debug_colors.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/macros.h"
+
 #include "cc/debug/debug_colors.h"
 
 #include "cc/trees/layer_tree_impl.h"
 
 namespace cc {
 
+static const int kPaintRectColors[][3] = {{0, 95, 0}, {0, 175, 0}, {0, 255, 0}};

[nduca, 2014/01/31 18:15:51]

please make the colors closer together in hue space. This amount of variation is
too large. Perhaps 255, 200, 175.

+
 static float Scale(float width, const LayerTreeImpl* tree_impl) {
   return width * (tree_impl ? tree_impl->device_scale_factor() : 1);
 }
 
 // ======= Layer border colors =======
 
 // Tiled content layers are orange.
 SkColor DebugColors::TiledContentLayerBorderColor() {
   return SkColorSetARGB(128, 255, 128, 0);
 }
@@ skipping 143 matching lines @@
   return SkColorSetRGB(128, 200, 245);
 }
 
 // Evicted tiles get pale red checkerboards.
 SkColor DebugColors::EvictedTileCheckerboardColor() {
   return SkColorSetRGB(255, 200, 200);
 }
 
 // ======= Debug rect colors =======
 
-// Paint rects in red.
-SkColor DebugColors::PaintRectBorderColor() {
-  return SkColorSetARGB(255, 255, 0, 0);
+// Paint rects in shades of green.
+SkColor DebugColors::PaintRectBorderColor(int color_index) {
+  int real_index = color_index % arraysize(kPaintRectColors);
+  return SkColorSetARGB(255,
+                        kPaintRectColors[real_index][0],
+                        kPaintRectColors[real_index][1],
+                        kPaintRectColors[real_index][2]);
 }
 int DebugColors::PaintRectBorderWidth() { return 2; }
-SkColor DebugColors::PaintRectFillColor() {
-  return SkColorSetARGB(30, 255, 0, 0);
+SkColor DebugColors::PaintRectFillColor(int color_index) {
+  int real_index = color_index % arraysize(kPaintRectColors);
+  return SkColorSetARGB(30,
+                        kPaintRectColors[real_index][0],
+                        kPaintRectColors[real_index][1],
+                        kPaintRectColors[real_index][2]);
 }
 
 // Property-changed rects in blue.
 SkColor DebugColors::PropertyChangedRectBorderColor() {
   return SkColorSetARGB(255, 0, 0, 255);
 }
 int DebugColors::PropertyChangedRectBorderWidth() { return 2; }
 SkColor DebugColors::PropertyChangedRectFillColor() {
   return SkColorSetARGB(30, 0, 0, 255);
 }
@@ skipping 107 matching lines @@
 SkColor DebugColors::MemoryDisplayTextColor() {
   return SkColorSetARGB(255, 220, 220, 220);
 }
 
 // Paint time display in green (similar to paint times in the WebInspector)
 SkColor DebugColors::PaintTimeDisplayTextAndGraphColor() {
   return SkColorSetRGB(75, 155, 55);
 }
 
 }  // namespace cc