Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1212213004: Simplify paint rect calculations in LayoutReplaced::shouldPaint (Closed)

Created:
5 years, 5 months ago by fs
Modified:
5 years, 5 months ago
Reviewers:
pdr.
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Simplify paint rect calculations in LayoutReplaced::shouldPaint Compute a paint rectangle based on visualOverflowRect() once, and then reuse that where needed to avoid calling said method 4 times. BUG=506432 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198240

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M Source/core/layout/LayoutReplaced.cpp View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
5 years, 5 months ago (2015-07-02 15:49:35 UTC) #2
pdr.
On 2015/07/02 at 15:49:35, fs wrote: > LGTM thanks!
5 years, 5 months ago (2015-07-02 19:16:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212213004/1
5 years, 5 months ago (2015-07-02 19:16:19 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 19:19:37 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198240

Powered by Google App Engine
This is Rietveld 408576698