Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1212213003: Revert of Fix tab_switching measurement bug. (Closed)

Created:
5 years, 5 months ago by dsinclair
Modified:
5 years, 5 months ago
CC:
bccheng, chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix tab_switching measurement bug. (patchset #9 id:160001 of https://codereview.chromium.org/1152763002/) Reason for revert: Looks like most of the perf tree has gone red with the tab_switching tests. Original issue's description: > Fix tab_switching measurement bug. > > _IsDone is always true, which makes it activate next tab regardless if the tab is rendered. It should wait until a reading of RWH_TabSwitchPaintDuration is obtained before switching to next tab. Also, it should pass each tab to GetHistogram(), not always the last tab. Unittest added. (./run_tests measurements.tab_switching). > > BUG=None > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect > > Committed: https://crrev.com/2eee3f91209b8ccf16e7f64c03d42fbafd724ebe > Cr-Commit-Position: refs/heads/master@{#337191} TBR=eakuefner@chromium.org,nednguyen@google.com,sullivan@chromium.org,deanliao@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/3e221f683216ac851c0c91b85864fc90d1bf49c3 Cr-Commit-Position: refs/heads/master@{#337224}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -134 lines) Patch
M tools/perf/benchmarks/benchmark_smoke_unittest.py View 3 chunks +5 lines, -11 lines 0 comments Download
M tools/perf/measurements/tab_switching.py View 3 chunks +13 lines, -23 lines 0 comments Download
D tools/perf/measurements/tab_switching_unittest.py View 1 chunk +0 lines, -100 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dsinclair
Created Revert of Fix tab_switching measurement bug.
5 years, 5 months ago (2015-07-02 15:17:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212213003/1
5 years, 5 months ago (2015-07-02 15:18:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-02 15:19:01 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 15:20:04 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e221f683216ac851c0c91b85864fc90d1bf49c3
Cr-Commit-Position: refs/heads/master@{#337224}

Powered by Google App Engine
This is Rietveld 408576698