Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 1212193003: MessageLoop: wire the unused static method in base::Thread (follow-up cleanup) (Closed)

Created:
5 years, 5 months ago by kinuko
Modified:
5 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MessageLoop: wire the unused static method in base::Thread (follow-up cleanup) Actually use the private static method (CreateUnbound) in base::Thread. I added the method in the last refactoring patch but forgot to use it; I can either remove the static method or use it, I do the latter in this patch as I thought leaving the private ctor of MessageLoop only for delegated use-case cleaner. BUG=465458 R=thakis@chromium.org Committed: https://crrev.com/547a48bb006e275f1192c983a634e911c8c1edbd Cr-Commit-Position: refs/heads/master@{#336710}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M base/message_loop/message_loop.h View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/thread.cc View 1 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kinuko
Nico, I realized that my previous patch left the ML ctors in a bit incomplete ...
5 years, 5 months ago (2015-06-29 10:18:41 UTC) #3
Nico
lgtm
5 years, 5 months ago (2015-06-29 16:20:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212193003/60001
5 years, 5 months ago (2015-06-30 01:27:14 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 5 months ago (2015-06-30 01:32:03 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 01:34:02 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/547a48bb006e275f1192c983a634e911c8c1edbd
Cr-Commit-Position: refs/heads/master@{#336710}

Powered by Google App Engine
This is Rietveld 408576698