Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Unified Diff: chrome/chrome_installer.gypi

Issue 1212163010: GN support for setup_unittests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iwt
Patch Set: both_gn_and_gyp Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/gn_migration.gypi ('k') | chrome/installer/setup/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_installer.gypi
diff --git a/chrome/chrome_installer.gypi b/chrome/chrome_installer.gypi
index 99ccd5c3ba945c3e9308783954ab8ff23a413d5c..e1b76f11df2ccaed6eb14c6af41dd69c96d99af4 100644
--- a/chrome/chrome_installer.gypi
+++ b/chrome/chrome_installer.gypi
@@ -306,6 +306,7 @@
],
},
{
+ # GN version: //chrome/installer/setup:setup_unittests
'target_name': 'setup_unittests',
'type': 'executable',
'dependencies': [
@@ -325,6 +326,7 @@
# below into a separate lib and then link both setup.exe and
# setup_unittests.exe against that.
'sources': [
+ '<(SHARED_INTERMEDIATE_DIR)/chrome/installer/util/installer_util_strings.rc',
'installer/mini_installer/chrome.release', # Move to lib
'installer/mini_installer/appid.h',
'installer/mini_installer/chrome_appid.cc',
@@ -351,8 +353,6 @@
'installer/setup/run_all_unittests.cc',
'installer/setup/setup_constants.cc', # Move to lib
'installer/setup/setup_constants.h', # Move to lib
- 'installer/setup/setup_unittests.rc',
- 'installer/setup/setup_unittests_resource.h',
'installer/setup/setup_util.cc',
'installer/setup/setup_util_unittest.cc',
'installer/setup/setup_util_unittest.h',
« no previous file with comments | « build/gn_migration.gypi ('k') | chrome/installer/setup/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698