Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4479)

Unified Diff: chrome/installer/setup/BUILD.gn

Issue 1212163010: GN support for setup_unittests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iwt
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/setup/BUILD.gn
diff --git a/chrome/installer/setup/BUILD.gn b/chrome/installer/setup/BUILD.gn
new file mode 100644
index 0000000000000000000000000000000000000000..aa3b3eca4289c539dd08fb5c4c253677a53662e7
--- /dev/null
+++ b/chrome/installer/setup/BUILD.gn
@@ -0,0 +1,58 @@
+# Copyright 2015 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import("//build/config/chrome_build.gni")
brettw 2015/07/01 17:08:09 I don't think you depend on this, so you can remov
grt (UTC plus 2) 2015/07/01 17:38:57 Done.
+import("//testing/test.gni")
+
+if (is_win) {
+ test("setup_unittests") {
+ # TODO(robertshield): Move the items marked with "Move to lib"
+ # below into a separate lib and then link both setup.exe and
+ # setup_unittests.exe against that.
+ sources = [
+ "../mini_installer/appid.h",
+ "../mini_installer/chrome.release", # Move to lib
+ "../mini_installer/chrome_appid.cc",
+ "../mini_installer/configuration.cc",
+ "../mini_installer/configuration.h",
+ "../mini_installer/configuration_test.cc",
+ "../mini_installer/decompress.cc",
+ "../mini_installer/decompress.h",
+ "../mini_installer/decompress_test.cc",
+ "../mini_installer/mini_string.cc",
+ "../mini_installer/mini_string.h",
+ "../mini_installer/mini_string_test.cc",
+ "app_launcher_installer.cc", # Move to lib
+ "app_launcher_installer.h", # Move to lib
+ "archive_patch_helper.cc", # Move to lib
+ "archive_patch_helper.h", # Move to lib
+ "archive_patch_helper_unittest.cc",
+ "install.cc", # Move to lib
+ "install.h", # Move to lib
+ "install_unittest.cc",
+ "install_worker.cc", # Move to lib
+ "install_worker.h", # Move to lib
+ "install_worker_unittest.cc",
+ "run_all_unittests.cc",
+ "setup_constants.cc", # Move to lib
+ "setup_constants.h", # Move to lib
+ "setup_util.cc",
+ "setup_util_unittest.cc",
+ "setup_util_unittest.h",
+ ]
+
+ deps = [
+ "//chrome/installer/util:strings",
brettw 2015/07/01 17:08:09 Sort these.
grt (UTC plus 2) 2015/07/01 17:38:57 Done.
+ "//chrome/installer/util:util",
+ "//base",
+ "//base:i18n",
+ "//base/test:test_support",
+ "//testing/gmock",
+ "//testing/gtest",
+ ]
+
+ # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+ configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698