GN support for setup_unittests.

GN support for setup_unittests.

BUG=470212
R=brettw@chromium.org

Committed: https://crrev.com/734e87b2ebe7ad248545616885a6e48d439084d3
Cr-Commit-Position: refs/heads/master@{#337443}

[grt (UTC plus 2), 2015-07-01 14:39:20]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-01 14:39:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1212163010/1

[commit-bot: I haz the power, 2015-07-01 15:16:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-01 15:16:49]

Dry run: This issue passed the CQ dry run.

[brettw, 2015-07-01 17:08:09]

Thanks for working on this!

https://codereview.chromium.org/1212163010/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1212163010/diff/1/BUILD.gn#newcode855
BUILD.gn:855: "//chrome/installer/setup:setup_unittests",
This list is trying to track the set of tests run on the bots. Is this test run
on the bots? I don't see it. Is it maybe official waterfall only?

To match GYP I believe this would go into the "both_gn_and_gyp" target above
inside a windows condition. Then you should also update build\gn_migration.gypi
and move setup_unittests from the "gyp_only" target to the both_gn_and_gyp one
so the builds are the same.

https://codereview.chromium.org/1212163010/diff/1/chrome/installer/setup/BUIL...
File chrome/installer/setup/BUILD.gn (right):

https://codereview.chromium.org/1212163010/diff/1/chrome/installer/setup/BUIL...
chrome/installer/setup/BUILD.gn:5: import("//build/config/chrome_build.gni")
I don't think you depend on this, so you can remove it.

https://codereview.chromium.org/1212163010/diff/1/chrome/installer/setup/BUIL...
chrome/installer/setup/BUILD.gn:46: "//chrome/installer/util:strings",
Sort these.

[grt (UTC plus 2), 2015-07-01 17:38:57]

https://codereview.chromium.org/1212163010/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1212163010/diff/1/BUILD.gn#newcode855
BUILD.gn:855: "//chrome/installer/setup:setup_unittests",
On 2015/07/01 17:08:09, brettw wrote:
> This list is trying to track the set of tests run on the bots. Is this test
run
> on the bots? I don't see it. Is it maybe official waterfall only?

At the moment, it's none of the above. I'm trying to get them on the bots
(http://crbug.com/153829), so I'd like to put them wherever makes the most sense
for that goal. Are they better placed here or in both_gn_and_gyp?

https://codereview.chromium.org/1212163010/diff/1/chrome/installer/setup/BUIL...
File chrome/installer/setup/BUILD.gn (right):

https://codereview.chromium.org/1212163010/diff/1/chrome/installer/setup/BUIL...
chrome/installer/setup/BUILD.gn:5: import("//build/config/chrome_build.gni")
On 2015/07/01 17:08:09, brettw wrote:
> I don't think you depend on this, so you can remove it.

Done.

https://codereview.chromium.org/1212163010/diff/1/chrome/installer/setup/BUIL...
chrome/installer/setup/BUILD.gn:46: "//chrome/installer/util:strings",
On 2015/07/01 17:08:09, brettw wrote:
> Sort these.

Done.

[grt (UTC plus 2), 2015-07-06 15:20:33]

https://codereview.chromium.org/1212163010/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1212163010/diff/1/BUILD.gn#newcode855
BUILD.gn:855: "//chrome/installer/setup:setup_unittests",
On 2015/07/01 17:38:57, grt wrote:
> On 2015/07/01 17:08:09, brettw wrote:
> > This list is trying to track the set of tests run on the bots. Is this test
> run
> > on the bots? I don't see it. Is it maybe official waterfall only?
> 
> At the moment, it's none of the above. I'm trying to get them on the bots
> (http://crbug.com/153829), so I'd like to put them wherever makes the most
sense
> for that goal. Are they better placed here or in both_gn_and_gyp?

FYI: I have https://codereview.chromium.org/1219923005/ out for review, which
will have setup_unittests built for the same targets in build/all.gyp as
installer_util_unittests. Thanks.

[grt (UTC plus 2), 2015-07-06 15:23:44]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-06 15:24:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1212163010/20001

[commit-bot: I haz the power, 2015-07-06 16:05:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-06 16:05:26]

Dry run: This issue passed the CQ dry run.

[brettw, 2015-07-06 17:07:50]

Then adding it here should be fine. But I think it should additionally be in the
GN/GYP targets I mentioned above so it's build as part of a normal full build.

[grt (UTC plus 2), 2015-07-06 17:24:43]

On 2015/07/06 17:07:50, brettw wrote:
> Then adding it here should be fine. But I think it should additionally be in
the
> GN/GYP targets I mentioned above so it's build as part of a normal full build.

Done. PTAL, thanks.

[brettw, 2015-07-06 17:29:08]

lgtm

[grt (UTC plus 2), 2015-07-06 17:29:36]

The CQ bit was checked by grt@chromium.org

[commit-bot: I haz the power, 2015-07-06 17:30:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1212163010/40001

[commit-bot: I haz the power, 2015-07-06 18:09:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-06 18:09:57]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

(exceeded global retry quota)

[grt (UTC plus 2), 2015-07-06 19:27:06]

The CQ bit was checked by grt@chromium.org

[commit-bot: I haz the power, 2015-07-06 19:29:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1212163010/40001

[commit-bot: I haz the power, 2015-07-06 19:36:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-06 19:39:26]

Patchset 3 (id:??) landed as
https://crrev.com/734e87b2ebe7ad248545616885a6e48d439084d3
Cr-Commit-Position: refs/heads/master@{#337443}