Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1212163009: Port remaining Sky tests to the new world (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Port remaining Sky tests to the new world These tests now run in the DOM-less world. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/452453c8ff9986ff12b74b2800168da680005e0d

Patch Set 1 #

Patch Set 2 : add #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -817 lines) Patch
M sky/tests/TestExpectations View 1 chunk +1 line, -1 line 0 comments Download
A + sky/tests/dom/appendChild.dart View 1 5 chunks +6 lines, -11 lines 0 comments Download
D sky/tests/dom/appendChild.sky View 1 chunk +0 lines, -83 lines 0 comments Download
A + sky/tests/dom/attribute_collection.dart View 1 3 chunks +1 line, -4 lines 0 comments Download
A + sky/tests/dom/attribute_collection-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D sky/tests/dom/document-child-mutations.sky View 1 chunk +0 lines, -108 lines 0 comments Download
D sky/tests/dom/document-child-mutations-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
A + sky/tests/dom/document_child_mutations.dart View 1 9 chunks +10 lines, -17 lines 0 comments Download
A + sky/tests/dom/document_child_mutations-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A sky/tests/dom/getChildElements.dart View 1 1 chunk +26 lines, -0 lines 0 comments Download
D sky/tests/dom/getChildElements.sky View 1 chunk +0 lines, -26 lines 0 comments Download
D sky/tests/dom/inherit-from-text.sky View 1 chunk +0 lines, -31 lines 0 comments Download
D sky/tests/dom/inherit-from-text-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
A + sky/tests/dom/ownerScope.dart View 1 2 chunks +0 lines, -4 lines 0 comments Download
D sky/tests/dom/ownerScope.sky View 1 chunk +0 lines, -51 lines 0 comments Download
A + sky/tests/dom/replaceChild.dart View 1 5 chunks +5 lines, -10 lines 0 comments Download
D sky/tests/dom/replaceChild.sky View 1 chunk +0 lines, -76 lines 0 comments Download
A + sky/tests/events/dispatcher.dart View 1 2 chunks +0 lines, -2 lines 0 comments Download
D sky/tests/events/dispatcher.sky View 1 chunk +0 lines, -103 lines 0 comments Download
D sky/tests/fast/images/resources/0colors.ico View Binary file 0 comments Download
D sky/tests/fast/images/resources/12-55.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/182.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/1bit.ico View Binary file 0 comments Download
D sky/tests/fast/images/resources/2-comp.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/2-dht.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/23-55.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/2entries.ico View Binary file 0 comments Download
D sky/tests/fast/images/resources/32bit.ico View Binary file 0 comments Download
D sky/tests/fast/images/resources/55.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/57.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/58.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/59.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/8bit.ico View Binary file 0 comments Download
D sky/tests/fast/images/resources/animated.gif View Binary file 0 comments Download
D sky/tests/fast/images/resources/animated-10color.gif View Binary file 0 comments Download
D sky/tests/fast/images/resources/animated-gif-with-offsets.gif View Binary file 0 comments Download
D sky/tests/fast/images/resources/animated2.gif View Binary file 0 comments Download
D sky/tests/fast/images/resources/bad.ico View Binary file 0 comments Download
D sky/tests/fast/images/resources/bad-png.png View Binary file 0 comments Download
D sky/tests/fast/images/resources/boston.gif View Binary file 0 comments Download
D sky/tests/fast/images/resources/broken-image-with-invalid-format.png View Binary file 0 comments Download
D sky/tests/fast/images/resources/busted-oval.png View Binary file 0 comments Download
D sky/tests/fast/images/resources/cmyk-jpeg.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/crbug.364830.webp View Binary file 0 comments Download
D sky/tests/fast/images/resources/dice.png View Binary file 0 comments Download
D sky/tests/fast/images/resources/exif-orientation-1-ul.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/exif-orientation-2-ur.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/exif-orientation-3-lr.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/exif-orientation-4-lol.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/exif-orientation-5-lu.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/exif-orientation-6-ru.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/exif-orientation-7-rl.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/exif-orientation-8-llo.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/exif-orientation-9-u.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/favicon.ico View Binary file 0 comments Download
D sky/tests/fast/images/resources/flip.webp View Binary file 0 comments Download
D sky/tests/fast/images/resources/flowchart.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/gif-loop-count.gif View Binary file 0 comments Download
D sky/tests/fast/images/resources/gif-loop-count.png View Binary file 0 comments Download
D sky/tests/fast/images/resources/green.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/green-24x24.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/green-256x256.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/green_rectangle.pdf View Binary file 0 comments Download
D sky/tests/fast/images/resources/grid-large.png View Binary file 0 comments Download
D sky/tests/fast/images/resources/grid-small.png View Binary file 0 comments Download
D sky/tests/fast/images/resources/icc-v2-gbr.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/invalid.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/invalid-animated-webp.webp View Binary file 0 comments Download
D sky/tests/fast/images/resources/invalid-animated-webp2.webp View Binary file 0 comments Download
D sky/tests/fast/images/resources/invalid-animated-webp3.webp View Binary file 0 comments Download
D sky/tests/fast/images/resources/invalid-animated-webp4.webp View Binary file 0 comments Download
D sky/tests/fast/images/resources/invalid_vp8_vp8x.webp View Binary file 0 comments Download
D sky/tests/fast/images/resources/jpeg-height-exif-orientation.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/large.webp View Binary file 0 comments Download
D sky/tests/fast/images/resources/large-gif-checkerboard.gif View Binary file 0 comments Download
D sky/tests/fast/images/resources/large-size-image-crash.jpeg View Binary file 0 comments Download
D sky/tests/fast/images/resources/lenna.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/lenna.png View Binary file 0 comments Download
D sky/tests/fast/images/resources/motion-jpeg-single-frame.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/mu.png View Binary file 0 comments Download
D sky/tests/fast/images/resources/oval.png View Binary file 0 comments Download
D sky/tests/fast/images/resources/palatted-color-png-gamma-one-color-profile.png View Binary file 0 comments Download
D sky/tests/fast/images/resources/pdf_test_landscape.pdf View Binary file 0 comments Download
D sky/tests/fast/images/resources/pixel-crack-image-background-webkit-transform-scale.png View Binary file 0 comments Download
D sky/tests/fast/images/resources/png-extra-row-crash.png View Binary file 0 comments Download
D sky/tests/fast/images/resources/png_per_row_alpha.png View Binary file 0 comments Download
D sky/tests/fast/images/resources/quicksort.gif View Binary file 0 comments Download
D sky/tests/fast/images/resources/red-at-12-oclock-with-color-profile.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/red-at-12-oclock-with-color-profile.png View Binary file 0 comments Download
D sky/tests/fast/images/resources/rgb-jpeg-blue.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/rgb-jpeg-green.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/rgb-jpeg-red.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/rgb-jpeg-with-adobe-marker-only.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/rgb-png-with-cmyk-color-profile.png View Binary file 0 comments Download
D sky/tests/fast/images/resources/short-app-extension-string.gif View Binary file 0 comments Download
D sky/tests/fast/images/resources/size-failure.gif View Binary file 0 comments Download
D sky/tests/fast/images/resources/test.webp View Binary file 0 comments Download
D sky/tests/fast/images/resources/test-load.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/test2.webp View Binary file 0 comments Download
D sky/tests/fast/images/resources/test3.webp View Binary file 0 comments Download
D sky/tests/fast/images/resources/truncated.webp View Binary file 0 comments Download
D sky/tests/fast/images/resources/truncated2.webp View Binary file 0 comments Download
D sky/tests/fast/images/resources/webp-animated.webp View Binary file 0 comments Download
D sky/tests/fast/images/resources/webp-animated-icc-xmp.webp View Binary file 0 comments Download
D sky/tests/fast/images/resources/webp-animated-large.webp View Binary file 0 comments Download
D sky/tests/fast/images/resources/webp-animated-no-blend.webp View Binary file 0 comments Download
D sky/tests/fast/images/resources/webp-animated-opaque.webp View Binary file 0 comments Download
D sky/tests/fast/images/resources/webp-animated-semitransparent1.webp View Binary file 0 comments Download
D sky/tests/fast/images/resources/webp-animated-semitransparent2.webp View Binary file 0 comments Download
D sky/tests/fast/images/resources/webp-animated-semitransparent3.webp View Binary file 0 comments Download
D sky/tests/fast/images/resources/webp-animated-semitransparent4.webp View Binary file 0 comments Download
D sky/tests/fast/images/resources/webp-color-profile-crash.webp View Binary file 0 comments Download
D sky/tests/fast/images/resources/webp-color-profile-lossless.webp View Binary file 0 comments Download
D sky/tests/fast/images/resources/webp-color-profile-lossy.webp View Binary file 0 comments Download
D sky/tests/fast/images/resources/webp-color-profile-lossy-alpha.webp View Binary file 0 comments Download
D sky/tests/fast/images/resources/wrong-block-length.gif View Binary file 0 comments Download
D sky/tests/fast/images/resources/ycbcr-with-cmyk-color-profile.jpg View Binary file 0 comments Download
D sky/tests/fast/images/resources/ycbcr-with-no-color-profile.jpg View Binary file 0 comments Download
D sky/tests/lowlevel/attribute-collection.sky View 1 chunk +0 lines, -67 lines 0 comments Download
D sky/tests/lowlevel/attribute-collection-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D sky/tests/lowlevel/create-document.sky View 1 chunk +0 lines, -20 lines 0 comments Download
D sky/tests/lowlevel/create-document-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
A + sky/tests/lowlevel/trivial.dart View 1 1 chunk +0 lines, -2 lines 0 comments Download
D sky/tests/lowlevel/trivial.sky View 1 chunk +0 lines, -7 lines 0 comments Download
A + sky/tests/lowlevel/unittest.dart View 1 2 chunks +0 lines, -2 lines 0 comments Download
D sky/tests/lowlevel/unittest.sky View 1 chunk +0 lines, -13 lines 0 comments Download
D sky/tests/resources/dom-utils.sky View 1 chunk +0 lines, -17 lines 0 comments Download
A + sky/tests/resources/dom_utils.dart View 1 2 chunks +0 lines, -2 lines 0 comments Download
A + sky/tests/services/network.dart View 1 2 chunks +0 lines, -5 lines 0 comments Download
D sky/tests/services/network.sky View 1 chunk +0 lines, -49 lines 0 comments Download
D sky/tests/styles/inline-style.sky View 1 chunk +0 lines, -23 lines 0 comments Download
D sky/tests/styles/inline-style-crash.sky View 1 chunk +0 lines, -28 lines 0 comments Download
D sky/tests/styles/inline-style-crash-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D sky/tests/styles/inline-style-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
A + sky/tests/styles/inline_style.dart View 1 2 chunks +5 lines, -8 lines 0 comments Download
A + sky/tests/styles/inline_style-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/tests/styles/inline_style_crash.dart View 1 3 chunks +7 lines, -6 lines 0 comments Download
A + sky/tests/styles/inline_style_crash-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 5 months ago (2015-06-30 20:43:00 UTC) #1
Hixie
lgtm
5 years, 5 months ago (2015-06-30 20:52:51 UTC) #2
abarth-chromium
5 years, 5 months ago (2015-06-30 20:53:25 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
452453c8ff9986ff12b74b2800168da680005e0d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698