Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1765)

Unified Diff: content/browser/site_instance_impl.cc

Issue 1212163007: Kill renderers for bad password forms in --site-per-process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/site_instance_impl.cc
diff --git a/content/browser/site_instance_impl.cc b/content/browser/site_instance_impl.cc
index 42d29421782ea48d17f1ae70cf9ea3fef376f025..ad335f51d3adb867a7dd081236de331e4674a65c 100644
--- a/content/browser/site_instance_impl.cc
+++ b/content/browser/site_instance_impl.cc
@@ -354,6 +354,12 @@ void SiteInstanceImpl::LockToOrigin() {
if (site_.SchemeIs(content::kGuestScheme))
return;
+ // TODO(creis, nick) https://crbug.com/510588 Chrome UI pages use the same
+ // site (chrome://chrome), so they can't be locked because the site being
+ // loaded doesn't match the SiteInstance.
+ if (site_.SchemeIs(content::kChromeUIScheme))
+ return;
+
ChildProcessSecurityPolicyImpl* policy =
ChildProcessSecurityPolicyImpl::GetInstance();
policy->LockToOrigin(process_->GetID(), site_);
« no previous file with comments | « content/browser/renderer_host/render_message_filter.cc ('k') | content/public/browser/child_process_security_policy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698