Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: components/password_manager/content/browser/content_password_manager_driver.h

Issue 1212163007: Kill renderers for bad password forms in --site-per-process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/browser/content_password_manager_driver.h
diff --git a/components/password_manager/content/browser/content_password_manager_driver.h b/components/password_manager/content/browser/content_password_manager_driver.h
index 9fd29046dae9a622235d113b2bb5e14895152f8a..9ccac908c80ee2dcafee85fa510accb859ca5952 100644
--- a/components/password_manager/content/browser/content_password_manager_driver.h
+++ b/components/password_manager/content/browser/content_password_manager_driver.h
@@ -30,6 +30,7 @@ class Message;
}
namespace password_manager {
+enum class BadMessageReason;
// There is one ContentPasswordManagerDriver per RenderFrameHost.
// The lifetime is managed by the ContentPasswordManagerDriverFactory.
@@ -73,6 +74,7 @@ class ContentPasswordManagerDriver : public PasswordManagerDriver {
// Pass-throughs to PasswordManager.
void OnPasswordFormsParsed(const std::vector<autofill::PasswordForm>& forms);
+ void PasswordFormsParsed(const std::vector<autofill::PasswordForm>& forms);
vabr (Chromium) 2015/07/17 07:25:10 Please make the name more informative. What about
lfg 2015/07/17 15:56:07 Done.
void OnPasswordFormsRendered(
const std::vector<autofill::PasswordForm>& visible_forms,
bool did_stop_loading);
@@ -82,6 +84,9 @@ class ContentPasswordManagerDriver : public PasswordManagerDriver {
void OnFocusedPasswordFormFound(const autofill::PasswordForm& password_form);
private:
+ bool CheckChildProcessSecurityPolicy(const GURL& url,
+ BadMessageReason reason);
+
content::RenderFrameHost* render_frame_host_;
PasswordManagerClient* client_;
PasswordGenerationManager password_generation_manager_;

Powered by Google App Engine
This is Rietveld 408576698