Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: components/password_manager/content/browser/bad_message.cc

Issue 1212163007: Kill renderers for bad password forms in --site-per-process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: starting histogram samples from 1 Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/bad_message.h" 5 #include "components/password_manager/content/browser/bad_message.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/metrics/histogram_macros.h" 8 #include "base/metrics/histogram_macros.h"
9 #include "content/public/browser/render_process_host.h" 9 #include "content/public/browser/render_process_host.h"
10 10
11 namespace extensions { 11 namespace password_manager {
12 namespace bad_message { 12 namespace bad_message {
13 13
14 void ReceivedBadMessage(content::RenderProcessHost* host, 14 void ReceivedBadMessage(content::RenderProcessHost* host,
15 BadMessageReason reason) { 15 BadMessageReason reason) {
16 LOG(ERROR) << "Terminating extension renderer for bad IPC message, reason " 16 LOG(ERROR)
17 << reason; 17 << "Terminating renderer for bad PasswordManager IPC message, reason "
18 UMA_HISTOGRAM_ENUMERATION("Stability.BadMessageTerminated.Extensions", reason, 18 << static_cast<int>(reason);
ncarter (slow) 2015/07/09 21:47:30 Leave this as log error, to match all the other ba
19 BAD_MESSAGE_MAX); 19 UMA_HISTOGRAM_ENUMERATION(
20 "Stability.BadMessageTerminated.PasswordManager",
21 static_cast<int>(reason),
22 static_cast<int>(BadMessageReason::BAD_MESSAGE_MAX));
20 host->ShutdownForBadMessage(); 23 host->ShutdownForBadMessage();
21 } 24 }
22 25
23 } // namespace bad_message 26 } // namespace bad_message
24 } // namespace extensions 27 } // namespace password_manager
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698