tools/metrics/histograms/histograms.xml - Issue 1212163007: Kill renderers for bad password forms in --site-per-process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 1212163007: Kill renderers for bad password forms in --site-per-process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adding test, bad message Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« components/password_manager/content/browser/content_password_manager_driver.cc ('K') | « content/public/browser/child_process_security_policy.h ('k') | tools/metrics/histograms/update_bad_message_reasons.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index ea110b9d7b4be2b0f7cfa6091f0e96200de9f0d0..12664ffd6b87d4717611de26be0d638317f3c928 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -41912,6 +41912,16 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="Stability.BadMessageTerminated.PasswordManager"

+ enum="BadMessageReasonPasswordManager">

+ <owner>nick@chromium.org</owner>

+ <owner>jamescook@chromium.org</owner>

+ <summary>

+ Count of processes killed because they sent a bad IPC that couldn't be

+ properly handled. Categories are the reasons (code locations) for the kills.

+ </summary>

+</histogram>

<owner>siggi@chromium.org</owner>

<owner>erikwright@chromium.org</owner>

@@ -50478,6 +50488,12 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</enum>

+<enum name="BadMessageReasonPasswordManager" type="int">

+

+ <int value="0" label="CPMD_BAD_ORIGIN"/>

+</enum>