Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Issue 1212163003: Using "defined" in macro causes undefined behavior. (Closed)

Created:
5 years, 5 months ago by Benedikt Meurer
Modified:
5 years, 5 months ago
Reviewers:
Sven Panne
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Using "defined" in macro causes undefined behavior. R=svenpanne@chromium.org Committed: https://crrev.com/cd85493faaa484e9d2a99a069c5f995629343752 Cr-Commit-Position: refs/heads/master@{#29342}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M include/v8config.h View 3 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 5 months ago (2015-06-29 11:12:12 UTC) #1
Sven Panne
lgtm
5 years, 5 months ago (2015-06-29 11:15:32 UTC) #2
Sven Panne
On 2015/06/29 11:15:32, Sven Panne wrote: > lgtm Just a side note: The example in ...
5 years, 5 months ago (2015-06-29 11:19:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212163003/1
5 years, 5 months ago (2015-06-29 11:20:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-29 11:47:54 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 11:48:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd85493faaa484e9d2a99a069c5f995629343752
Cr-Commit-Position: refs/heads/master@{#29342}

Powered by Google App Engine
This is Rietveld 408576698