Source/platform/exported/WebServicePortProviderClient.cpp - Issue 1212123003: Componentization: make symbols visible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/exported/WebServicePortProviderClient.cpp

Issue 1212123003: Componentization: make symbols visible. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/exported/WebServicePortProviderClient.cpp

diff --git a/Source/platform/exported/WebMessagePortChannelClient.cpp b/Source/platform/exported/WebServicePortProviderClient.cpp

similarity index 51%

copy from Source/platform/exported/WebMessagePortChannelClient.cpp

copy to Source/platform/exported/WebServicePortProviderClient.cpp

index 1f853ed8527a8dc80a0bd2690a3ab037233210d1..1be42a0496a16344cf71dc7500b1c16056e8af55 100644

--- a/Source/platform/exported/WebMessagePortChannelClient.cpp

+++ b/Source/platform/exported/WebServicePortProviderClient.cpp

@@ -3,10 +3,10 @@

// found in the LICENSE file.

#include "config.h"

-#include "public/platform/WebMessagePortChannelClient.h"

+#include "public/platform/modules/navigator_services/WebServicePortProviderClient.h"

-// This WebMessagePortChannelClient.cpp, which includes only config.h and

-// WebMessagePortChannelClient.h, should be in Source/platform/exported,

-// because WebMessagePortChannelClient is not compiled without this cpp.

+// This WebServicePortProviderClient.cpp, which includes only config.h and

+// WebServicePortProvierClient.h, should be in Source/platform/exported,

+// because WebServicePortProviderClient is not compiled without this cpp.

// So if we don't have this cpp, we will see unresolved symbol error

// when constructor/destructor's address is required.