Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceOwnProperties.cpp

Issue 1212123003: Componentization: make symbols visible. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/core/V8TestInterfaceOwnProperties.cpp
diff --git a/Source/bindings/tests/results/core/V8TestInterfaceOwnProperties.cpp b/Source/bindings/tests/results/core/V8TestInterfaceOwnProperties.cpp
index 12a2d9bfdb2548405312a4fc353f4424c776a7fc..35a0bdefdadf92da05ce5abd4badcc71823442b0 100644
--- a/Source/bindings/tests/results/core/V8TestInterfaceOwnProperties.cpp
+++ b/Source/bindings/tests/results/core/V8TestInterfaceOwnProperties.cpp
@@ -19,7 +19,16 @@
namespace blink {
+// Suppress warning: global constructors, because struct WrapperTypeInfo is trivial
+// and does not depend on another global objects.
+#if defined(COMPONENT_BUILD) && defined(WIN32) && COMPILER(CLANG)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wglobal-constructors"
+#endif
const WrapperTypeInfo V8TestInterfaceOwnProperties::wrapperTypeInfo = { gin::kEmbedderBlink, V8TestInterfaceOwnProperties::domTemplate, V8TestInterfaceOwnProperties::refObject, V8TestInterfaceOwnProperties::derefObject, V8TestInterfaceOwnProperties::trace, 0, 0, V8TestInterfaceOwnProperties::preparePrototypeObject, V8TestInterfaceOwnProperties::installConditionallyEnabledProperties, "TestInterfaceOwnProperties", &V8TestInterfaceEmpty::wrapperTypeInfo, WrapperTypeInfo::WrapperTypeObjectPrototype, WrapperTypeInfo::ObjectClassId, WrapperTypeInfo::NotInheritFromEventTarget, WrapperTypeInfo::Independent, WrapperTypeInfo::RefCountedObject };
+#if defined(COMPONENT_BUILD) && defined(WIN32) && COMPILER(CLANG)
+#pragma clang diagnostic pop
+#endif
// This static member must be declared by DEFINE_WRAPPERTYPEINFO in TestInterfaceOwnProperties.h.
// For details, see the comment of DEFINE_WRAPPERTYPEINFO in
@@ -127,10 +136,19 @@ static void doNotExposeJSAccessorAttributeAttributeSetterCallback(v8::Local<v8::
} // namespace TestInterfaceOwnPropertiesV8Internal
+// Suppress warning: global constructors, because AttributeConfiguration is trivial
+// and does not depend on another global objects.
+#if defined(COMPONENT_BUILD) && defined(WIN32) && COMPILER(CLANG)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wglobal-constructors"
+#endif
static const V8DOMConfiguration::AttributeConfiguration V8TestInterfaceOwnPropertiesAttributes[] = {
{"noExposeJSAccessorAttribute", TestInterfaceOwnPropertiesV8Internal::noExposeJSAccessorAttributeAttributeGetterCallback, TestInterfaceOwnPropertiesV8Internal::noExposeJSAccessorAttributeAttributeSetterCallback, 0, 0, 0, static_cast<v8::AccessControl>(v8::DEFAULT), static_cast<v8::PropertyAttribute>(v8::None), V8DOMConfiguration::ExposedToAllScripts, V8DOMConfiguration::OnInstance, V8DOMConfiguration::CheckHolder},
{"doNotExposeJSAccessorAttribute", TestInterfaceOwnPropertiesV8Internal::doNotExposeJSAccessorAttributeAttributeGetterCallback, TestInterfaceOwnPropertiesV8Internal::doNotExposeJSAccessorAttributeAttributeSetterCallback, 0, 0, 0, static_cast<v8::AccessControl>(v8::DEFAULT), static_cast<v8::PropertyAttribute>(v8::None), V8DOMConfiguration::ExposedToAllScripts, V8DOMConfiguration::OnInstance, V8DOMConfiguration::CheckHolder},
};
+#if defined(COMPONENT_BUILD) && defined(WIN32) && COMPILER(CLANG)
+#pragma clang diagnostic pop
+#endif
static const V8DOMConfiguration::AccessorConfiguration V8TestInterfaceOwnPropertiesAccessors[] = {
{"exposeJSAccessorAttribute", TestInterfaceOwnPropertiesV8Internal::exposeJSAccessorAttributeAttributeGetterCallback, TestInterfaceOwnPropertiesV8Internal::exposeJSAccessorAttributeAttributeSetterCallback, 0, 0, 0, static_cast<v8::AccessControl>(v8::DEFAULT), static_cast<v8::PropertyAttribute>(v8::None), V8DOMConfiguration::ExposedToAllScripts, V8DOMConfiguration::OnPrototype, V8DOMConfiguration::CheckHolder},

Powered by Google App Engine
This is Rietveld 408576698