Source/bindings/tests/results/core/V8TestInterfaceConstructor3.cpp - Issue 1212123003: Componentization: make symbols visible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceConstructor3.cpp

Issue 1212123003: Componentization: make symbols visible. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/templates/interface.cpp ('K') | « Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp ('k') | Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp » ('j') | Source/core/layout/HitTestCache.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterfaceConstructor3.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterfaceConstructor3.cpp b/Source/bindings/tests/results/core/V8TestInterfaceConstructor3.cpp

index 03ef8a83ef446e8c46770387802eba2a42172977..f417c07399e84bd49055b1e68212775223b2b5f9 100644

--- a/Source/bindings/tests/results/core/V8TestInterfaceConstructor3.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterfaceConstructor3.cpp

@@ -20,7 +20,16 @@

namespace blink {

+// Suppress warning: global constructors, because struct WrapperTypeInfo is trivial

+// and does not depend on another global objects.

+#if defined(COMPONENT_BUILD) && defined(WIN32) && COMPILER(CLANG)

+#pragma clang diagnostic push

+#pragma clang diagnostic ignored "-Wglobal-constructors"

+#endif

const WrapperTypeInfo V8TestInterfaceConstructor3::wrapperTypeInfo = { gin::kEmbedderBlink, V8TestInterfaceConstructor3::domTemplate, V8TestInterfaceConstructor3::refObject, V8TestInterfaceConstructor3::derefObject, V8TestInterfaceConstructor3::trace, 0, 0, V8TestInterfaceConstructor3::preparePrototypeObject, V8TestInterfaceConstructor3::installConditionallyEnabledProperties, "TestInterfaceConstructor3", 0, WrapperTypeInfo::WrapperTypeObjectPrototype, WrapperTypeInfo::ObjectClassId, WrapperTypeInfo::NotInheritFromEventTarget, WrapperTypeInfo::Independent, WrapperTypeInfo::RefCountedObject };

+#if defined(COMPONENT_BUILD) && defined(WIN32) && COMPILER(CLANG)

+#pragma clang diagnostic pop

+#endif

// This static member must be declared by DEFINE_WRAPPERTYPEINFO in TestInterfaceConstructor3.h.

// For details, see the comment of DEFINE_WRAPPERTYPEINFO in