Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp - Issue 1212123003: Componentization: make symbols visible.

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp

Issue 1212123003: Componentization: make symbols visible. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/templates/interface.cpp ('K') | « Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp ('k') | Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp » ('j') | Source/core/layout/HitTestCache.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp b/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp

index 6380ca8ae018a070cff47f3da457bfe50072a698..50174ac2e7a8a37d4f31ac3a57bab2783565205a 100644

--- a/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp

@@ -25,7 +25,16 @@

namespace blink {

+// Suppress warning: global constructors, because struct WrapperTypeInfo is trivial

+// and does not depend on another global objects.

+#if defined(COMPONENT_BUILD) && defined(WIN32) && COMPILER(CLANG)

+#pragma clang diagnostic push

+#pragma clang diagnostic ignored "-Wglobal-constructors"

+#endif

const WrapperTypeInfo V8TestInterfaceConstructor::wrapperTypeInfo = { gin::kEmbedderBlink, V8TestInterfaceConstructor::domTemplate, V8TestInterfaceConstructor::refObject, V8TestInterfaceConstructor::derefObject, V8TestInterfaceConstructor::trace, 0, 0, V8TestInterfaceConstructor::preparePrototypeObject, V8TestInterfaceConstructor::installConditionallyEnabledProperties, "TestInterfaceConstructor", 0, WrapperTypeInfo::WrapperTypeObjectPrototype, WrapperTypeInfo::ObjectClassId, WrapperTypeInfo::NotInheritFromEventTarget, WrapperTypeInfo::Independent, WrapperTypeInfo::RefCountedObject };

+#if defined(COMPONENT_BUILD) && defined(WIN32) && COMPILER(CLANG)

+#pragma clang diagnostic pop

+#endif

// This static member must be declared by DEFINE_WRAPPERTYPEINFO in TestInterfaceConstructor.h.

// For details, see the comment of DEFINE_WRAPPERTYPEINFO in

@@ -241,7 +250,16 @@ static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info)

} // namespace TestInterfaceConstructorV8Internal

+// Suppress warning: global constructors, because struct WrapperTypeInfo is trivial

+// and does not depend on another global objects.

+#if defined(COMPONENT_BUILD) && defined(WIN32) && COMPILER(CLANG)

+#pragma clang diagnostic push

+#pragma clang diagnostic ignored "-Wglobal-constructors"

+#endif

const WrapperTypeInfo V8TestInterfaceConstructorConstructor::wrapperTypeInfo = { gin::kEmbedderBlink, V8TestInterfaceConstructorConstructor::domTemplate, V8TestInterfaceConstructor::refObject, V8TestInterfaceConstructor::derefObject, V8TestInterfaceConstructor::trace, 0, 0, V8TestInterfaceConstructor::preparePrototypeObject, V8TestInterfaceConstructor::installConditionallyEnabledProperties, "TestInterfaceConstructor", 0, WrapperTypeInfo::WrapperTypeObjectPrototype, WrapperTypeInfo::ObjectClassId, WrapperTypeInfo::NotInheritFromEventTarget, WrapperTypeInfo::Independent, WrapperTypeInfo::RefCountedObject };

+#if defined(COMPONENT_BUILD) && defined(WIN32) && COMPILER(CLANG)

+#pragma clang diagnostic pop

+#endif

static void V8TestInterfaceConstructorConstructorCallback(const v8::FunctionCallbackInfo<v8::Value>& info)

{