Source/bindings/tests/results/core/V8DataView.cpp - Issue 1212123003: Componentization: make symbols visible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8DataView.cpp

Issue 1212123003: Componentization: make symbols visible. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/templates/interface.cpp ('K') | « Source/bindings/tests/results/core/V8ArrayBufferView.cpp ('k') | Source/bindings/tests/results/core/V8SVGTestInterface.cpp » ('j') | Source/core/layout/HitTestCache.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8DataView.cpp

diff --git a/Source/bindings/tests/results/core/V8DataView.cpp b/Source/bindings/tests/results/core/V8DataView.cpp

index a0b2932e5778f620f3c83a3c5d917d773a89ae79..067195365cadb3cd2cc7c1d27ae8111abbdc6f54 100644

--- a/Source/bindings/tests/results/core/V8DataView.cpp

+++ b/Source/bindings/tests/results/core/V8DataView.cpp

@@ -20,7 +20,16 @@

namespace blink {

+// Suppress warning: global constructors, because struct WrapperTypeInfo is trivial

+// and does not depend on another global objects.

+#if defined(COMPONENT_BUILD) && defined(WIN32) && COMPILER(CLANG)

+#pragma clang diagnostic push

+#pragma clang diagnostic ignored "-Wglobal-constructors"

+#endif

const WrapperTypeInfo V8DataView::wrapperTypeInfo = { gin::kEmbedderBlink, 0, V8DataView::refObject, V8DataView::derefObject, V8DataView::trace, 0, 0, V8DataView::preparePrototypeObject, V8DataView::installConditionallyEnabledProperties, "DataView", &V8ArrayBufferView::wrapperTypeInfo, WrapperTypeInfo::WrapperTypeObjectPrototype, WrapperTypeInfo::ObjectClassId, WrapperTypeInfo::NotInheritFromEventTarget, WrapperTypeInfo::Independent, WrapperTypeInfo::RefCountedObject };

+#if defined(COMPONENT_BUILD) && defined(WIN32) && COMPILER(CLANG)

+#pragma clang diagnostic pop

+#endif

// This static member must be declared by DEFINE_WRAPPERTYPEINFO in TestDataView.h.

// For details, see the comment of DEFINE_WRAPPERTYPEINFO in