Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 1212113003: Add telemetry_gpu_unittests.isolate. (Closed)

Created:
5 years, 6 months ago by Ken Russell (switch to Gerrit)
Modified:
5 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, Sergiy Byelozyorov, aiolos (Not reviewing), dtu, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add telemetry_gpu_unittests.isolate. This will make it easier to run this test suite on the bots. Refactored Telemetry isolates into: - telemetry.isolate: contains just Telemetry's logic and dependencies (bitmaptools). Moved this from chrome/ into content/ to match its dependencies. - telemetry_chrome_test.isolate: describes Telemetry tests which run using the Chromium browser. Currently telemetry_gpu_test.isolate is the only consumer of this isolate. The new test target will be added to the bots in a subsequent commit; some more work is needed to do so. BUG=495868 R=zmo@chromium.org,phajdan.jr@chromium.org,maruel@google.com TBR=maruel@chromium.org Committed: https://crrev.com/57cf0faa30d1fed831fcddd9b6b07049582091ae Cr-Commit-Position: refs/heads/master@{#336392}

Patch Set 1 #

Patch Set 2 : Depend on telemetry_base from telemetry_chrome_test_base. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -57 lines) Patch
M chrome/chrome_tests.gypi View 1 2 chunks +3 lines, -3 lines 0 comments Download
D chrome/telemetry.isolate View 1 chunk +0 lines, -37 lines 0 comments Download
A chrome/telemetry_chrome_test.isolate View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/telemetry_gpu_test.isolate View 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 1 chunk +20 lines, -0 lines 0 comments Download
A + content/telemetry.isolate View 2 chunks +13 lines, -16 lines 0 comments Download
A content/telemetry_gpu_unittests.isolate View 1 chunk +27 lines, -0 lines 1 comment Download

Messages

Total messages: 20 (7 generated)
Ken Russell (switch to Gerrit)
5 years, 6 months ago (2015-06-25 23:47:46 UTC) #2
Ken Russell (switch to Gerrit)
bajones/zmo: please review maruel or csharp: please review .isolate changes phjadan.jr: please review and advise ...
5 years, 6 months ago (2015-06-25 23:52:41 UTC) #4
Zhenyao Mo
On 2015/06/25 23:47:46, Ken Russell wrote: LGTM
5 years, 6 months ago (2015-06-25 23:54:41 UTC) #5
Marc-Antoine Ruel (Google)
that sounds good, lgtm https://codereview.chromium.org/1212113003/diff/20001/content/telemetry_gpu_unittests.isolate File content/telemetry_gpu_unittests.isolate (right): https://codereview.chromium.org/1212113003/diff/20001/content/telemetry_gpu_unittests.isolate#newcode17 content/telemetry_gpu_unittests.isolate:17: '../content/test/gpu/', I'd prefer to have ...
5 years, 6 months ago (2015-06-26 02:10:41 UTC) #7
Paweł Hajdan Jr.
LGTM just in case For me this change doesn't seem to make anything easier or ...
5 years, 6 months ago (2015-06-26 13:10:05 UTC) #9
Ken Russell (switch to Gerrit)
On 2015/06/26 13:10:05, Paweł Hajdan Jr. wrote: > LGTM just in case > > For ...
5 years, 6 months ago (2015-06-26 15:36:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212113003/20001
5 years, 6 months ago (2015-06-26 15:37:05 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/74358)
5 years, 6 months ago (2015-06-26 15:45:29 UTC) #14
Ken Russell (switch to Gerrit)
maruel@: looks like you lgtm'd this from the wrong account. I'm TBR'ing it to you.
5 years, 6 months ago (2015-06-26 16:55:00 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212113003/20001
5 years, 6 months ago (2015-06-26 16:56:44 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-26 17:04:48 UTC) #18
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/57cf0faa30d1fed831fcddd9b6b07049582091ae Cr-Commit-Position: refs/heads/master@{#336392}
5 years, 6 months ago (2015-06-26 17:05:53 UTC) #19
M-A Ruel
5 years, 6 months ago (2015-06-26 18:06:23 UTC) #20
Message was sent while issue was closed.
On 2015/06/26 16:55:00, Ken Russell wrote:
> maruel@: looks like you lgtm'd this from the wrong account. I'm TBR'ing it to
> you.

oops, lgtm.

Powered by Google App Engine
This is Rietveld 408576698