Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 121203002: Use window.URL instead of window.webkitURL. (Closed)

Created:
6 years, 12 months ago by davidben
Modified:
6 years, 11 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, jam, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, eroman, darin-cc_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Use window.URL instead of window.webkitURL. It was unprefixed back in Chrome 23. BUG=330691 TEST=no behavior change Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243664

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase. Files got renamed. #

Patch Set 3 : window.URL -> URL in user_images_grid.js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -27 lines) Patch
M chrome/browser/resources/chromeos/user_images_grid.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/feedback/js/take_screenshot.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/net_internals/export_view.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/profiler/profiler.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/sync_internals/data.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/translate_internals/translate_internals.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/api/desktopCapture/app.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_codelab8_webresources.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_external.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/downloads/download-dangerous-blob.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/tab_capture/end_to_end.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/tab_capture/performance.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/platform_apps/iframes/main.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webrtc/manual/peerconnection-multi.html View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/resources/media/dump_creator.js View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/media/getusermedia.html View 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/data/media/peerconnection-call.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/examples/video_effects/video_effects.html View 4 chunks +5 lines, -5 lines 0 comments Download
M ppapi/tests/test_video_destination.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_video_source.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
davidben
This is a pretty mechanical change. Just picked reviewers based on OWNERS and such. dbeam: ...
6 years, 12 months ago (2013-12-28 21:34:51 UTC) #1
no longer working on chromium
owner stamp, lgtm on media
6 years, 11 months ago (2013-12-30 12:36:35 UTC) #2
yzshen1
PPAPI LGTM Thanks!
6 years, 11 months ago (2013-12-30 17:23:13 UTC) #3
Dan Beam
lgtm
6 years, 11 months ago (2013-12-30 20:15:55 UTC) #4
mkearney1
lgtm
6 years, 11 months ago (2014-01-08 16:37:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/121203002/1
6 years, 11 months ago (2014-01-08 16:38:41 UTC) #6
commit-bot: I haz the power
Failed to apply patch for chrome/test/data/extensions/api_test/tab_capture/experimental/end_to_end.js: While running patch -p1 --forward --force --no-backup-if-mismatch; can't find ...
6 years, 11 months ago (2014-01-08 16:38:48 UTC) #7
arv (Not doing code reviews)
LGTM Thanks for getting rid of the legacy references https://codereview.chromium.org/121203002/diff/1/chrome/browser/resources/chromeos/user_images_grid.js File chrome/browser/resources/chromeos/user_images_grid.js (right): https://codereview.chromium.org/121203002/diff/1/chrome/browser/resources/chromeos/user_images_grid.js#newcode298 chrome/browser/resources/chromeos/user_images_grid.js:298: ...
6 years, 11 months ago (2014-01-08 16:41:12 UTC) #8
davidben
Apparently some files got renamed. Sending to the CQ again. https://codereview.chromium.org/121203002/diff/1/chrome/browser/resources/chromeos/user_images_grid.js File chrome/browser/resources/chromeos/user_images_grid.js (right): https://codereview.chromium.org/121203002/diff/1/chrome/browser/resources/chromeos/user_images_grid.js#newcode298 ...
6 years, 11 months ago (2014-01-08 16:47:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/121203002/270001
6 years, 11 months ago (2014-01-08 16:48:39 UTC) #10
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 22:04:34 UTC) #11
Message was sent while issue was closed.
Change committed as 243664

Powered by Google App Engine
This is Rietveld 408576698