 Chromium Code Reviews
 Chromium Code Reviews Issue 1212023004:
  Convert all usages of mojo::ErrorHandler in //device/serial to callbacks.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1212023004:
  Convert all usages of mojo::ErrorHandler in //device/serial to callbacks.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: device/serial/data_source_sender.h | 
| diff --git a/device/serial/data_source_sender.h b/device/serial/data_source_sender.h | 
| index a8c2c634712e9a9a35e5f3ee23d95e1ee883da4d..eed24d25851d2268e704f2bebfd972092ca27558 100644 | 
| --- a/device/serial/data_source_sender.h | 
| +++ b/device/serial/data_source_sender.h | 
| @@ -19,8 +19,7 @@ namespace device { | 
| // A DataSourceSender is an interface between a source of data and a | 
| // DataSourceClient. | 
| class DataSourceSender : public base::RefCounted<DataSourceSender>, | 
| - public serial::DataSource, | 
| - public mojo::ErrorHandler { | 
| + public serial::DataSource { | 
| public: | 
| typedef base::Callback<void(scoped_ptr<WritableBuffer>)> ReadyCallback; | 
| typedef base::Callback<void()> ErrorCallback; | 
| @@ -49,8 +48,8 @@ class DataSourceSender : public base::RefCounted<DataSourceSender>, | 
| void Init(uint32_t buffer_size) override; | 
| void Resume() override; | 
| void ReportBytesReceived(uint32_t bytes_sent) override; | 
| - // Invoked in the event of a connection error. Calls DispatchFatalError(). | 
| 
Reilly Grant (use Gerrit)
2015/07/06 23:03:14
Can you preserve "Calls DispatchFatalError()."?
 
tanay.c
2015/07/07 05:29:12
Done. PTAL.
 | 
| - void OnConnectionError() override; | 
| + // mojo error handler | 
| + void OnConnectionError(); | 
| // Gets more data to send to the DataSourceClient. | 
| void GetMoreData(); |