Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1501)

Side by Side Diff: device/serial/data_sender.h

Issue 1212023004: Convert all usages of mojo::ErrorHandler in //device/serial to callbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « device/serial/data_receiver.cc ('k') | device/serial/data_sender.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef DEVICE_SERIAL_DATA_SENDER_H_ 5 #ifndef DEVICE_SERIAL_DATA_SENDER_H_
6 #define DEVICE_SERIAL_DATA_SENDER_H_ 6 #define DEVICE_SERIAL_DATA_SENDER_H_
7 7
8 #include <queue> 8 #include <queue>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
11 #include "base/memory/linked_ptr.h" 11 #include "base/memory/linked_ptr.h"
12 #include "base/strings/string_piece.h" 12 #include "base/strings/string_piece.h"
13 #include "device/serial/buffer.h" 13 #include "device/serial/buffer.h"
14 #include "device/serial/data_stream.mojom.h" 14 #include "device/serial/data_stream.mojom.h"
15 #include "third_party/mojo/src/mojo/public/cpp/system/data_pipe.h" 15 #include "third_party/mojo/src/mojo/public/cpp/system/data_pipe.h"
16 16
17 namespace device { 17 namespace device {
18 18
19 // A DataSender sends data to a DataSink. 19 // A DataSender sends data to a DataSink.
20 class DataSender : public mojo::ErrorHandler { 20 class DataSender {
21 public: 21 public:
22 typedef base::Callback<void(uint32_t bytes_sent)> DataSentCallback; 22 typedef base::Callback<void(uint32_t bytes_sent)> DataSentCallback;
23 typedef base::Callback<void(uint32_t bytes_sent, int32_t error)> 23 typedef base::Callback<void(uint32_t bytes_sent, int32_t error)>
24 SendErrorCallback; 24 SendErrorCallback;
25 typedef base::Callback<void()> CancelCallback; 25 typedef base::Callback<void()> CancelCallback;
26 26
27 // Constructs a DataSender to send data to |sink|, using a buffer size of 27 // Constructs a DataSender to send data to |sink|, using a buffer size of
28 // |buffer_size|, with connection errors reported as |fatal_error_value|. 28 // |buffer_size|, with connection errors reported as |fatal_error_value|.
29 DataSender(mojo::InterfacePtr<serial::DataSink> sink, 29 DataSender(mojo::InterfacePtr<serial::DataSink> sink,
30 uint32_t buffer_size, 30 uint32_t buffer_size,
31 int32_t fatal_error_value); 31 int32_t fatal_error_value);
32 32
33 ~DataSender() override; 33 ~DataSender();
34 34
35 // Starts an asynchronous send of |data|. If the send completes successfully, 35 // Starts an asynchronous send of |data|. If the send completes successfully,
36 // |callback| will be called. Otherwise, |error_callback| will be called with 36 // |callback| will be called. Otherwise, |error_callback| will be called with
37 // the error. If there is a cancel in progress or there has been a connection 37 // the error. If there is a cancel in progress or there has been a connection
38 // error, this will not start a send and returns false. It is the caller's 38 // error, this will not start a send and returns false. It is the caller's
39 // responsibility to ensure |data| remains valid until one of |callback| and 39 // responsibility to ensure |data| remains valid until one of |callback| and
40 // |error_callback| is called. 40 // |error_callback| is called.
41 bool Send(const base::StringPiece& data, 41 bool Send(const base::StringPiece& data,
42 const DataSentCallback& callback, 42 const DataSentCallback& callback,
43 const SendErrorCallback& error_callback); 43 const SendErrorCallback& error_callback);
44 44
45 // Requests the cancellation of any in-progress sends. Calls to Send() will 45 // Requests the cancellation of any in-progress sends. Calls to Send() will
46 // fail until |callback| is called. 46 // fail until |callback| is called.
47 bool Cancel(int32_t error, const CancelCallback& callback); 47 bool Cancel(int32_t error, const CancelCallback& callback);
48 48
49 private: 49 private:
50 class PendingSend; 50 class PendingSend;
51 51
52 // Invoked when a PendingSend completes. 52 // Invoked when a PendingSend completes.
53 void SendComplete(); 53 void SendComplete();
54 54
55 // Invoked when a PendingSend fails with |error|. 55 // Invoked when a PendingSend fails with |error|.
56 void SendFailed(int32_t error); 56 void SendFailed(int32_t error);
57 57
58 // mojo::ErrorHandler override. 58 // mojo error handler
59 void OnConnectionError() override; 59 void OnConnectionError();
60 60
61 // Dispatches a cancel callback if one is pending. 61 // Dispatches a cancel callback if one is pending.
62 void RunCancelCallback(); 62 void RunCancelCallback();
63 63
64 // Shuts down this DataSender and dispatches fatal errors to all pending 64 // Shuts down this DataSender and dispatches fatal errors to all pending
65 // operations. 65 // operations.
66 void ShutDown(); 66 void ShutDown();
67 67
68 // The control connection to the data sink. 68 // The control connection to the data sink.
69 mojo::InterfacePtr<serial::DataSink> sink_; 69 mojo::InterfacePtr<serial::DataSink> sink_;
(...skipping 11 matching lines...) Expand all
81 81
82 // Whether we have encountered a fatal error and shut down. 82 // Whether we have encountered a fatal error and shut down.
83 bool shut_down_; 83 bool shut_down_;
84 84
85 DISALLOW_COPY_AND_ASSIGN(DataSender); 85 DISALLOW_COPY_AND_ASSIGN(DataSender);
86 }; 86 };
87 87
88 } // namespace device 88 } // namespace device
89 89
90 #endif // DEVICE_SERIAL_DATA_SENDER_H_ 90 #endif // DEVICE_SERIAL_DATA_SENDER_H_
OLDNEW
« no previous file with comments | « device/serial/data_receiver.cc ('k') | device/serial/data_sender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698