Issue 1212013004: Fix some dart analyzer warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1212013004: Fix some dart analyzer warnings. (Closed)

Created:
5 years, 5 months ago by Matt Perry

Modified:
5 years, 5 months ago

Reviewers:
Hixie, abarth-chromium

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -5 lines)			Patch
	M	sky/sdk/lib/widgets/drawer.dart	View		1 chunk	+0 lines, -4 lines	0 comments	Download
	M	sky/sdk/lib/widgets/material.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 6 (2 generated)

Matt Perry

This fixes all the warnings aside from the AnimatedType<> one.

5 years, 5 months ago (2015-07-01 23:50:31 UTC) #2

abarth-chromium

Committed patchset #1 (id:1) manually as 22b8fdeb98a62e235144283d018b1956c50a9132 (presubmit successful).

5 years, 5 months ago (2015-07-02 15:08:52 UTC) #4

abarth-chromium

5 years, 5 months ago (2015-07-02 15:49:36 UTC) #6

Message was sent while issue was closed.

There were still three left, which I fixed in
https://codereview.chromium.org/1213573006