Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Unified Diff: pkg/analyzer/lib/src/task/dart.dart

Issue 1211993003: Get more tests passing using the new task model (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/task/html.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/task/dart.dart
diff --git a/pkg/analyzer/lib/src/task/dart.dart b/pkg/analyzer/lib/src/task/dart.dart
index 62fed3be1866d76cfc386fb077736ee9e2474424..3db3a5c135a1afde82b3d6a498a10a9546efa87e 100644
--- a/pkg/analyzer/lib/src/task/dart.dart
+++ b/pkg/analyzer/lib/src/task/dart.dart
@@ -3381,6 +3381,20 @@ class ScanDartTask extends SourceBasedAnalysisTask {
@override
void internalPerform() {
Source source = getRequiredSource();
+
+ RecordingErrorListener errorListener = new RecordingErrorListener();
+ if (context.getModificationStamp(target.source) < 0) {
+ String message = 'Content could not be read';
+ if (context is InternalAnalysisContext) {
+ CacheEntry entry = (context as InternalAnalysisContext).getCacheEntry(target);
+ CaughtException exception = entry.exception;
+ if (exception != null) {
+ message = exception.toString();
+ }
+ }
+ errorListener.onError(new AnalysisError(
+ source, 0, 0, ScannerErrorCode.UNABLE_GET_CONTENT, [message]));
+ }
if (target is DartScript) {
DartScript script = target;
List<ScriptFragment> fragments = script.fragments;
@@ -3392,7 +3406,6 @@ class ScanDartTask extends SourceBasedAnalysisTask {
}
ScriptFragment fragment = fragments[0];
- RecordingErrorListener errorListener = new RecordingErrorListener();
Scanner scanner = new Scanner(source,
new SubSequenceReader(fragment.content, fragment.offset),
errorListener);
@@ -3407,7 +3420,6 @@ class ScanDartTask extends SourceBasedAnalysisTask {
} else if (target is Source) {
String content = getRequiredInput(CONTENT_INPUT_NAME);
- RecordingErrorListener errorListener = new RecordingErrorListener();
Scanner scanner =
new Scanner(source, new CharSequenceReader(content), errorListener);
scanner.preserveComments = context.analysisOptions.preserveComments;
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/task/html.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698