Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1211993002: DevTools: Refactor: Split timeline overview strips into components (Closed)

Created:
5 years, 6 months ago by alph
Modified:
5 years, 5 months ago
Reviewers:
caseq, pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: Refactor: Split timeline overview strips into components Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197933

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -220 lines) Patch
M Source/devtools/front_end/timeline/TimelineEventOverview.js View 12 chunks +257 lines, -213 lines 2 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 chunk +7 lines, -1 line 0 comments Download
M Source/devtools/front_end/timeline/timelinePanel.css View 1 chunk +17 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
alph
5 years, 6 months ago (2015-06-25 17:58:37 UTC) #2
caseq
lgtm https://codereview.chromium.org/1211993002/diff/1/Source/devtools/front_end/timeline/TimelineEventOverview.js File Source/devtools/front_end/timeline/TimelineEventOverview.js (right): https://codereview.chromium.org/1211993002/diff/1/Source/devtools/front_end/timeline/TimelineEventOverview.js#newcode34 Source/devtools/front_end/timeline/TimelineEventOverview.js:34: * @param {string} id nit: id -> class ...
5 years, 5 months ago (2015-06-26 15:53:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211993002/1
5 years, 5 months ago (2015-06-26 15:56:03 UTC) #6
alph
https://codereview.chromium.org/1211993002/diff/1/Source/devtools/front_end/timeline/TimelineEventOverview.js File Source/devtools/front_end/timeline/TimelineEventOverview.js (right): https://codereview.chromium.org/1211993002/diff/1/Source/devtools/front_end/timeline/TimelineEventOverview.js#newcode34 Source/devtools/front_end/timeline/TimelineEventOverview.js:34: * @param {string} id On 2015/06/26 15:53:47, caseq wrote: ...
5 years, 5 months ago (2015-06-26 16:11:19 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-06-26 18:24:02 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197933

Powered by Google App Engine
This is Rietveld 408576698