Revert of Adding a serviceURI param to SpeechRecognition

Revert of Adding a serviceURI param to SpeechRecognition  (patchset #4 id:60001 of https://codereview.chromium.org/1034833002/)

Reason for revert:
Reverting this patch since we will not be supporting serviceURI param. 

Original issue's description:
> Adding a serviceURI param to SpeechRecognition so users can pass the param over to the speech side.
> 
> The speech API supports serviceURI param in SpeechRecognition. 
> https://dvcs.w3.org/hg/speech-api/raw-file/tip/speechapi.html#dfn-serviceuri
> 
> BUG=480516
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194498

TBR=mkwst@chromium.org,dmazzoni@chromium.org,sigbjornf@opera.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=480516

[kirtia, 2015-06-25 17:23:28]

Created Revert of Adding a serviceURI param to SpeechRecognition

[commit-bot: I haz the power, 2015-06-25 17:23:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1211973002/1

[commit-bot: I haz the power, 2015-06-25 17:23:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-25 17:23:56]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[dmazzoni, 2015-06-25 17:50:00]

lgtm

Can you link to a thread or bug explaining why we dropped support?

[kirtia, 2015-06-25 18:18:44]

On 2015/06/25 17:50:00, dmazzoni wrote:
> lgtm
> 
> Can you link to a thread or bug explaining why we dropped support?

I have added a link to the thread from blink-dev. 
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/82LcTDrhshw/pG...

[Mike West, 2015-06-25 19:31:22]

LGTM 2.

[kirtia, 2015-06-25 23:08:33]

The CQ bit was checked by kirtia@chromium.org

[kirtia, 2015-06-25 23:08:34]

The CQ bit was unchecked by kirtia@chromium.org

[kirtia, 2015-06-25 23:08:41]

The CQ bit was checked by kirtia@chromium.org

[commit-bot: I haz the power, 2015-06-25 23:08:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1211973002/1

[commit-bot: I haz the power, 2015-06-25 23:09:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-25 23:09:23]

Failed to apply patch for Source/modules/speech/SpeechRecognition.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/modules/speech/SpeechRecognition.cpp
  Hunk #1 FAILED at 35.
  Hunk #2 FAILED at 59.
  2 out of 2 hunks FAILED -- saving rejects to file
Source/modules/speech/SpeechRecognition.cpp.rej

Patch:       Source/modules/speech/SpeechRecognition.cpp
Index: Source/modules/speech/SpeechRecognition.cpp
diff --git a/Source/modules/speech/SpeechRecognition.cpp
b/Source/modules/speech/SpeechRecognition.cpp
index
f36b6933dc71836ac90cb1924e01585b63f3f872..051e89e1f1b27d94f3993734db7abebd0ae788d9
100644
--- a/Source/modules/speech/SpeechRecognition.cpp
+++ b/Source/modules/speech/SpeechRecognition.cpp
@@ -35,7 +35,6 @@
 #include "modules/speech/SpeechRecognitionController.h"
 #include "modules/speech/SpeechRecognitionError.h"
 #include "modules/speech/SpeechRecognitionEvent.h"
-#include "platform/weborigin/KURL.h"
 
 namespace blink {
 
@@ -59,15 +58,8 @@
         return;
     }
 
-    KURL url(m_serviceURI);
-    // Throw an error if serviceuri is not empty and url is invalid.
-    if (!m_serviceURI.empty() && !url.isValid()) {
-        exceptionState.throwDOMException(ValidationError, "serviceuri is
invalid");
-        return;
-    }
-
     m_finalResults.clear();
-    m_controller->start(this, m_grammars, m_lang, url, m_continuous,
m_interimResults, m_maxAlternatives, m_audioTrack);
+    m_controller->start(this, m_grammars, m_lang, m_continuous,
m_interimResults, m_maxAlternatives, m_audioTrack);
     m_started = true;
 }

[commit-bot: I haz the power, 2015-06-25 23:09:24]

The CQ bit was unchecked by commit-bot@chromium.org

[kirtia, 2015-06-26 18:32:35]

The CQ bit was checked by kirtia@chromium.org

[commit-bot: I haz the power, 2015-06-26 18:32:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1211973002/1

[commit-bot: I haz the power, 2015-06-26 18:33:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-26 18:33:37]

Failed to apply patch for Source/modules/speech/SpeechRecognition.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/modules/speech/SpeechRecognition.cpp
  Hunk #1 FAILED at 35.
  Hunk #2 FAILED at 59.
  2 out of 2 hunks FAILED -- saving rejects to file
Source/modules/speech/SpeechRecognition.cpp.rej

Patch:       Source/modules/speech/SpeechRecognition.cpp
Index: Source/modules/speech/SpeechRecognition.cpp
diff --git a/Source/modules/speech/SpeechRecognition.cpp
b/Source/modules/speech/SpeechRecognition.cpp
index
f36b6933dc71836ac90cb1924e01585b63f3f872..051e89e1f1b27d94f3993734db7abebd0ae788d9
100644
--- a/Source/modules/speech/SpeechRecognition.cpp
+++ b/Source/modules/speech/SpeechRecognition.cpp
@@ -35,7 +35,6 @@
 #include "modules/speech/SpeechRecognitionController.h"
 #include "modules/speech/SpeechRecognitionError.h"
 #include "modules/speech/SpeechRecognitionEvent.h"
-#include "platform/weborigin/KURL.h"
 
 namespace blink {
 
@@ -59,15 +58,8 @@
         return;
     }
 
-    KURL url(m_serviceURI);
-    // Throw an error if serviceuri is not empty and url is invalid.
-    if (!m_serviceURI.empty() && !url.isValid()) {
-        exceptionState.throwDOMException(ValidationError, "serviceuri is
invalid");
-        return;
-    }
-
     m_finalResults.clear();
-    m_controller->start(this, m_grammars, m_lang, url, m_continuous,
m_interimResults, m_maxAlternatives, m_audioTrack);
+    m_controller->start(this, m_grammars, m_lang, m_continuous,
m_interimResults, m_maxAlternatives, m_audioTrack);
     m_started = true;
 }

[commit-bot: I haz the power, 2015-06-26 18:33:53]

The CQ bit was unchecked by commit-bot@chromium.org

[kirtia, 2015-07-15 22:44:20]

The CQ bit was checked by kirtia@chromium.org

[commit-bot: I haz the power, 2015-07-15 22:44:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1211973002/1

[commit-bot: I haz the power, 2015-07-15 22:45:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-15 22:45:32]

Failed to apply patch for Source/modules/speech/SpeechRecognition.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/modules/speech/SpeechRecognition.cpp
  Hunk #1 FAILED at 35.
  Hunk #2 FAILED at 59.
  2 out of 2 hunks FAILED -- saving rejects to file
Source/modules/speech/SpeechRecognition.cpp.rej

Patch:       Source/modules/speech/SpeechRecognition.cpp
Index: Source/modules/speech/SpeechRecognition.cpp
diff --git a/Source/modules/speech/SpeechRecognition.cpp
b/Source/modules/speech/SpeechRecognition.cpp
index
f36b6933dc71836ac90cb1924e01585b63f3f872..051e89e1f1b27d94f3993734db7abebd0ae788d9
100644
--- a/Source/modules/speech/SpeechRecognition.cpp
+++ b/Source/modules/speech/SpeechRecognition.cpp
@@ -35,7 +35,6 @@
 #include "modules/speech/SpeechRecognitionController.h"
 #include "modules/speech/SpeechRecognitionError.h"
 #include "modules/speech/SpeechRecognitionEvent.h"
-#include "platform/weborigin/KURL.h"
 
 namespace blink {
 
@@ -59,15 +58,8 @@
         return;
     }
 
-    KURL url(m_serviceURI);
-    // Throw an error if serviceuri is not empty and url is invalid.
-    if (!m_serviceURI.empty() && !url.isValid()) {
-        exceptionState.throwDOMException(ValidationError, "serviceuri is
invalid");
-        return;
-    }
-
     m_finalResults.clear();
-    m_controller->start(this, m_grammars, m_lang, url, m_continuous,
m_interimResults, m_maxAlternatives, m_audioTrack);
+    m_controller->start(this, m_grammars, m_lang, m_continuous,
m_interimResults, m_maxAlternatives, m_audioTrack);
     m_started = true;
 }

[commit-bot: I haz the power, 2015-07-15 22:45:58]

The CQ bit was unchecked by commit-bot@chromium.org

[kirtia, 2015-07-15 23:02:05]

The CQ bit was checked by kirtia@chromium.org

[commit-bot: I haz the power, 2015-07-15 23:02:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1211973002/1

[commit-bot: I haz the power, 2015-07-15 23:03:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-15 23:03:52]

Failed to apply patch for Source/modules/speech/SpeechRecognition.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/modules/speech/SpeechRecognition.cpp
  Hunk #1 FAILED at 35.
  Hunk #2 FAILED at 59.
  2 out of 2 hunks FAILED -- saving rejects to file
Source/modules/speech/SpeechRecognition.cpp.rej

Patch:       Source/modules/speech/SpeechRecognition.cpp
Index: Source/modules/speech/SpeechRecognition.cpp
diff --git a/Source/modules/speech/SpeechRecognition.cpp
b/Source/modules/speech/SpeechRecognition.cpp
index
f36b6933dc71836ac90cb1924e01585b63f3f872..051e89e1f1b27d94f3993734db7abebd0ae788d9
100644
--- a/Source/modules/speech/SpeechRecognition.cpp
+++ b/Source/modules/speech/SpeechRecognition.cpp
@@ -35,7 +35,6 @@
 #include "modules/speech/SpeechRecognitionController.h"
 #include "modules/speech/SpeechRecognitionError.h"
 #include "modules/speech/SpeechRecognitionEvent.h"
-#include "platform/weborigin/KURL.h"
 
 namespace blink {
 
@@ -59,15 +58,8 @@
         return;
     }
 
-    KURL url(m_serviceURI);
-    // Throw an error if serviceuri is not empty and url is invalid.
-    if (!m_serviceURI.empty() && !url.isValid()) {
-        exceptionState.throwDOMException(ValidationError, "serviceuri is
invalid");
-        return;
-    }
-
     m_finalResults.clear();
-    m_controller->start(this, m_grammars, m_lang, url, m_continuous,
m_interimResults, m_maxAlternatives, m_audioTrack);
+    m_controller->start(this, m_grammars, m_lang, m_continuous,
m_interimResults, m_maxAlternatives, m_audioTrack);
     m_started = true;
 }

[commit-bot: I haz the power, 2015-07-15 23:04:05]

The CQ bit was unchecked by commit-bot@chromium.org

[sof, 2015-07-22 12:00:04]

(The revert failed, fwiw.)