Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 1211963002: Remove some old unused code, add a missing include (Closed)

Created:
5 years, 6 months ago by Ted Mielczarek
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

This binarystream code was left over from my source server work that I removed a while back. It was breaking a cross-compile I was doing so removing it seemed easier than fixing it since nothing uses it anyway. I also had to add a missing include to minidump.h to make my cross compile work.

Patch Set 1 #

Patch Set 2 : Actually remove files #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -778 lines) Patch
M Makefile.am View 6 chunks +1 line, -20 lines 0 comments Download
M Makefile.in View 22 chunks +1 line, -110 lines 0 comments Download
M src/google_breakpad/processor/minidump.h View 1 chunk +2 lines, -0 lines 1 comment Download
D src/processor/binarystream.h View 1 1 chunk +0 lines, -92 lines 0 comments Download
D src/processor/binarystream.cc View 1 1 chunk +0 lines, -124 lines 0 comments Download
D src/processor/binarystream_unittest.cc View 1 1 chunk +0 lines, -432 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Ted Mielczarek
5 years, 6 months ago (2015-06-25 17:16:22 UTC) #1
Ted Mielczarek
On 2015/06/25 17:16:22, Ted Mielczarek wrote: ... I apparently neglected to actually rm the files.
5 years, 6 months ago (2015-06-25 17:17:03 UTC) #2
Ted Mielczarek
Lei: review ping? (Apparently everyone is on vacation this month, I guess...)
5 years, 5 months ago (2015-07-15 12:33:21 UTC) #4
Lei Zhang
Yep, it's Xmas in July. ;) https://codereview.chromium.org/1211963002/diff/20001/src/google_breakpad/processor/minidump.h File src/google_breakpad/processor/minidump.h (right): https://codereview.chromium.org/1211963002/diff/20001/src/google_breakpad/processor/minidump.h#newcode82 src/google_breakpad/processor/minidump.h:82: #include <stdint.h> Is ...
5 years, 5 months ago (2015-07-15 17:07:30 UTC) #5
Lei Zhang
5 years, 5 months ago (2015-07-15 17:08:40 UTC) #6
On 2015/07/15 17:07:30, Lei Zhang wrote:
> Is this here by accident?

Err, brain is still on vacation and can't read. lgtm

Powered by Google App Engine
This is Rietveld 408576698