Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Unified Diff: net/spdy/spdy_session.cc

Issue 1211933005: Initial (partial) implementation of HPKP violation reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: style fixes, comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/ssl_client_socket_openssl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_session.cc
diff --git a/net/spdy/spdy_session.cc b/net/spdy/spdy_session.cc
index a648ae9ff8c0cb2d3191505118a76e1a1a8336a9..49a2d942b3a951e82329be2dc096ca96c1a62cac 100644
--- a/net/spdy/spdy_session.cc
+++ b/net/spdy/spdy_session.cc
@@ -598,10 +598,14 @@ bool SpdySession::CanPool(TransportSecurityState* transport_security_state,
return false;
std::string pinning_failure_log;
+ // TODO(estark): replace 0 below with the port of the connection
+ // (though it won't actually be used since reports aren't getting
+ // sent).
if (!transport_security_state->CheckPublicKeyPins(
- new_hostname,
- ssl_info.is_issued_by_known_root,
- ssl_info.public_key_hashes,
+ new_hostname, ssl_info.is_issued_by_known_root,
+ ssl_info.public_key_hashes, 0, ssl_info.unverified_cert,
+ ssl_info.cert,
+ TransportSecurityState::DO_NOT_SEND_PUBLIC_KEY_PIN_REPORT,
&pinning_failure_log)) {
return false;
}
« no previous file with comments | « net/socket/ssl_client_socket_openssl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698